Skip to content

Commit a0e9eca

Browse files
fjlARR4N
authored andcommitted
internal/debug: remove memsize (ethereum#30253)
Removing because memsize will very likely be broken by Go 1.23. See fjl/memsize#4
1 parent 59e3c27 commit a0e9eca

File tree

4 files changed

+0
-9
lines changed

4 files changed

+0
-9
lines changed

cmd/geth/main.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -349,8 +349,6 @@ func geth(ctx *cli.Context) error {
349349
// it unlocks any requested accounts, and starts the RPC/IPC interfaces and the
350350
// miner.
351351
func startNode(ctx *cli.Context, stack *node.Node, backend ethapi.Backend, isConsole bool) {
352-
debug.Memsize.Add("node", stack)
353-
354352
// Start up the node itself
355353
utils.StartNode(ctx, stack, isConsole)
356354

go.mod

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ require (
2424
github.com/fatih/color v1.13.0
2525
github.com/ferranbt/fastssz v0.1.2
2626
github.com/fjl/gencodec v0.0.0-20230517082657-f9840df7b83e
27-
github.com/fjl/memsize v0.0.2
2827
github.com/fsnotify/fsnotify v1.6.0
2928
github.com/gballet/go-libpcsclite v0.0.0-20190607065134-2772fd86a8ff
3029
github.com/gballet/go-verkle v0.1.1-0.20231031103413-a67434b50f46

go.sum

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,6 @@ github.com/ferranbt/fastssz v0.1.2 h1:Dky6dXlngF6Qjc+EfDipAkE83N5I5DE68bY6O0VLNP
191191
github.com/ferranbt/fastssz v0.1.2/go.mod h1:X5UPrE2u1UJjxHA8X54u04SBwdAQjG2sFtWs39YxyWs=
192192
github.com/fjl/gencodec v0.0.0-20230517082657-f9840df7b83e h1:bBLctRc7kr01YGvaDfgLbTwjFNW5jdp5y5rj8XXBHfY=
193193
github.com/fjl/gencodec v0.0.0-20230517082657-f9840df7b83e/go.mod h1:AzA8Lj6YtixmJWL+wkKoBGsLWy9gFrAzi4g+5bCKwpY=
194-
github.com/fjl/memsize v0.0.2 h1:27txuSD9or+NZlnOWdKUxeBzTAUkWCVh+4Gf2dWFOzA=
195-
github.com/fjl/memsize v0.0.2/go.mod h1:VvhXpOYNQvB+uIk2RvXzuaQtkQJzzIx6lSBe1xv7hi0=
196194
github.com/flosch/pongo2 v0.0.0-20190707114632-bbf5a6c351f4/go.mod h1:T9YF2M40nIgbVgp3rreNmTged+9HrbNTIQf1PsaIiTA=
197195
github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo=
198196
github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4IgpuI1SZQ=

internal/debug/flags.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,13 @@ import (
3030
"github.com/ava-labs/libevm/log"
3131
"github.com/ava-labs/libevm/metrics"
3232
"github.com/ava-labs/libevm/metrics/exp"
33-
"github.com/fjl/memsize/memsizeui"
3433
"github.com/mattn/go-colorable"
3534
"github.com/mattn/go-isatty"
3635
"github.com/urfave/cli/v2"
3736
"golang.org/x/exp/slog"
3837
"gopkg.in/natefinch/lumberjack.v2"
3938
)
4039

41-
var Memsize memsizeui.Handler
42-
4340
var (
4441
verbosityFlag = &cli.IntFlag{
4542
Name: "verbosity",
@@ -313,7 +310,6 @@ func StartPProf(address string, withMetrics bool) {
313310
if withMetrics {
314311
exp.Exp(metrics.DefaultRegistry)
315312
}
316-
http.Handle("/memsize/", http.StripPrefix("/memsize", &Memsize))
317313
log.Info("Starting pprof server", "addr", fmt.Sprintf("http://%s/debug/pprof", address))
318314
go func() {
319315
if err := http.ListenAndServe(address, nil); err != nil {

0 commit comments

Comments
 (0)