sync: coreth PR #1198: style: enable testifylint linter #1795
+521
−537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Oppenheimer <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]> Co-authored-by: Austin Larson <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]>
alarso16
reviewed
Oct 10, 2025
| cacheConfig := &CacheConfig{Pruning: true, CommitInterval: 4096, StateHistory: uint64(tipBufferSize)} | ||
| w := NewTrieWriter(m, cacheConfig) | ||
| assert := assert.New(t) | ||
| require := require.New(t) |
There was a problem hiding this comment.
When do you decide to use require instead of assert?
There was a problem hiding this comment.
Whenever the linter complains - is this not required?
There was a problem hiding this comment.
Not really, but a bunch of these files still use assert
There was a problem hiding this comment.
Do you want me to get rid of more of the asserts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync ava-labs/coreth#1198