diff --git a/rpc/websocket_test.go b/rpc/websocket_test.go index c6d6c0a1d3..48073aea0f 100644 --- a/rpc/websocket_test.go +++ b/rpc/websocket_test.go @@ -89,8 +89,11 @@ func TestWebsocketOriginCheck(t *testing.T) { } // This test checks whether calls exceeding the request size limit are rejected. -/* +// +// This test times out occasionally due to context timeout differences with go-ethereum. +// These differences are not critical, so this test can simply be skipped. func TestWebsocketLargeCall(t *testing.T) { + t.Skip("Flaky") t.Parallel() var ( @@ -124,10 +127,13 @@ func TestWebsocketLargeCall(t *testing.T) { t.Fatal("no error for too large call") } } -*/ // This test checks whether the wsMessageSizeLimit option is obeyed. +// +// This test times out occasionally due to context timeout differences with go-ethereum. +// These differences are not critical, so this test can simply be skipped. func TestWebsocketLargeRead(t *testing.T) { + t.Skip("Flaky") t.Parallel() var ( @@ -271,7 +277,11 @@ func TestClientWebsocketPing(t *testing.T) { } // This checks that the websocket transport can deal with large messages. +// +// This test is upstream from go-ethereum but is skipped because it is flaky. +// Error message: call failed: websocket: close 1006 (abnormal closure): unexpected EOF func TestClientWebsocketLargeMessage(t *testing.T) { + t.Skip("Flaky") var ( srv = NewServer(0) httpsrv = httptest.NewServer(srv.WebsocketHandler(nil)) diff --git a/scripts/known_flakes.txt b/scripts/known_flakes.txt index a16c56dd87..47b834c9fb 100644 --- a/scripts/known_flakes.txt +++ b/scripts/known_flakes.txt @@ -1,5 +1,2 @@ TestChainIndexerWithChildren -TestClientCancelWebsocket -TestClientWebsocketLargeMessage TestVMShutdownWhileSyncing -TestWebsocketLargeRead