more clippy and adding toolchain file

Author: avacore1337

rust-toolchain.toml

@@ -0,0 +1,4 @@
+[toolchain]
+channel = "nightly-2021-05-11"
+components = [ "rustfmt", "clippy" ]
+profile = "minimal"

src/db/mod.rs

@@ -21,7 +21,7 @@ pub type PgPool = Pool<ConnectionManager<PgConnection>>;
 
 pub fn get_single_connection() -> PgConnection {
     PgConnection::establish(&database_url())
-        .expect(&format!("Error connecting to {}", database_url()))
+        .unwrap_or_else(|_| panic!("Error connecting to {}", database_url()))
 }
 
 // fn init_pool() -> Result<PgPool, PoolError> {

src/db/queue_entries.rs

@@ -157,10 +157,10 @@ pub fn remove_all(conn: &PgConnection) -> Result<(), diesel::result::Error> {
 
 pub fn remove_multiple(
     conn: &PgConnection,
-    entries: &Vec<QueueEntry>,
+    entries: &[QueueEntry],
 ) -> Result<(), diesel::result::Error> {
     diesel::delete(queue_entries::table.filter(
-        queue_entries::id.eq_any::<Vec<i32>>(entries.into_iter().map(|entry| entry.id).collect()),
+        queue_entries::id.eq_any::<Vec<i32>>(entries.iter().map(|entry| entry.id).collect()),
     ))
     .execute(conn)
     .map(|_| ())

src/util.rs

@@ -75,9 +75,9 @@ fn convert_to_ldap_user(mut rs: Vec<ResultEntry>) -> Option<LdapUser> {
     let mut entry = SearchEntry::construct(rs.pop()?);
     // println!("Got entry:\n{:?}", entry);
     Some(LdapUser {
-        username: entry.attrs.get_mut(LDAP_USERNAME)?.pop()?.to_string(),
-        ugkthid: entry.attrs.get_mut(LDAP_UGKTHID)?.pop()?.to_string(),
-        realname: entry.attrs.get_mut(LDAP_REALNAME)?.pop()?.to_string(),
+        username: entry.attrs.get_mut(LDAP_USERNAME)?.pop()?,
+        ugkthid: entry.attrs.get_mut(LDAP_UGKTHID)?.pop()?,
+        realname: entry.attrs.get_mut(LDAP_REALNAME)?.pop()?,
     })
 }