Skip to content

Fix project creation error handling #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix project creation error handling #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/cli/src/models/project.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ impl ProjectGenerationResult {
}

pub fn add_error(&mut self, error: String) {
self.success = false;
self.errors.push(error);
}
}
}
16 changes: 6 additions & 10 deletions apps/cli/src/services/project_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ impl DefaultProjectService {

impl ProjectService for DefaultProjectService {
fn create_project(&self, config: &ProjectConfig) -> Result<ProjectGenerationResult> {
let mut result = ProjectGenerationResult::failure(vec![]);
let mut result = ProjectGenerationResult::success(config.name.clone(), Vec::new());

// Validate project name
if let Err(e) = self.validate_project_name(&config.name) {
Expand Down Expand Up @@ -167,16 +167,14 @@ impl ProjectService for DefaultProjectService {
return Ok(result);
}

let mut files_created = Vec::new();

// Create directories
for dir in &template.structure.directories {
let dir_path = project_path.join(dir);
if let Err(e) = fs::create_dir_all(&dir_path) {
result.add_error(format!("Failed to create directory '{}': {}", dir, e));
continue;
}
files_created.push(format!("📁 {}", dir));
result.files_created.push(format!("📁 {}", dir));
}

// Create files
Expand All @@ -202,7 +200,7 @@ impl ProjectService for DefaultProjectService {
continue;
}

files_created.push(format!("📄 {}", file.path));
result.files_created.push(format!("📄 {}", file.path));
}

// Create config files
Expand All @@ -215,13 +213,11 @@ impl ProjectService for DefaultProjectService {
continue;
}

files_created.push(format!("⚙️ {}", config_file.name));
result.files_created.push(format!("⚙️ {}", config_file.name));
}
result.project_path = Some(config.name.clone());

Ok(ProjectGenerationResult::success(
config.name.clone(),
files_created,
))
Ok(result)
}

fn list_templates(&self) -> Vec<ProjectTemplate> {
Expand Down
Loading