Skip to content

Commit 3fe4c40

Browse files
authored
Only create the cache directory when needed (#2628)
Avoid potential permission issues if we don't use the cache dir anyway, see <#1128 (comment)>.
1 parent 99ab93a commit 3fe4c40

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

lib/api.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,8 @@ class Api extends Emittery {
111111
}
112112
};
113113

114-
let cacheDir;
115114
let testFiles;
116115
try {
117-
cacheDir = this._createCacheDir();
118116
testFiles = await globs.findTests({cwd: this.options.projectDir, ...apiOptions.globs});
119117
if (selectedFiles.length === 0) {
120118
selectedFiles = filter.length === 0 ? testFiles : globs.applyTestFileFilter({
@@ -189,7 +187,7 @@ class Api extends Emittery {
189187

190188
const {providers = []} = this.options;
191189
const providerStates = (await Promise.all(providers.map(async ({type, main}) => {
192-
const state = await main.compile({cacheDir, files: testFiles});
190+
const state = await main.compile({cacheDir: this._createCacheDir(), files: testFiles});
193191
return state === null ? null : {type, state};
194192
}))).filter(state => state !== null);
195193

0 commit comments

Comments
 (0)