Add number of timeouts in test summary

il3ven · web-flow · commit 714c474a49d4 · 2022-05-16T12:05:36.000+02:00
Fixes #2639.
diff --git a/lib/reporters/default.js b/lib/reporters/default.js
@@ -660,6 +660,10 @@ export default class Reporter {
 			this.lineWriter.writeLine(colors.error(`${this.stats.uncaughtExceptions} uncaught ${plur('exception', this.stats.uncaughtExceptions)}`));
 		}
 
+		if (this.stats.timeouts > 0) {
+			this.lineWriter.writeLine(colors.error(`${this.stats.timeouts} ${plur('test', this.stats.timeouts)} remained pending after a timeout`));
+		}
+
 		if (this.previousFailures > 0) {
 			this.lineWriter.writeLine(colors.error(`${this.previousFailures} previous ${plur('failure', this.previousFailures)} in test files that were not rerun`));
 		}
diff --git a/lib/run-status.js b/lib/run-status.js
@@ -125,7 +125,10 @@ export default class RunStatus extends Emittery {
 			case 'timeout':
 				event.pendingTests = this.pendingTests;
 				this.pendingTests = new Map();
-				stats.timeouts++;
+				for (const testsInFile of event.pendingTests.values()) {
+					stats.timeouts += testsInFile.size;
+				}
+
 				break;
 			case 'interrupt':
 				event.pendingTests = this.pendingTests;
diff --git a/test-tap/reporters/default.timeoutinmultiplefiles.v12.log b/test-tap/reporters/default.timeoutinmultiplefiles.v12.log
@@ -30,4 +30,5 @@
   [90m─[39m
 
   [32m4 tests passed[39m
+  [31m5 tests remained pending after a timeout[39m
 ---tty-stream-chunk-separator
diff --git a/test-tap/reporters/default.timeoutinmultiplefiles.v14.log b/test-tap/reporters/default.timeoutinmultiplefiles.v14.log
@@ -30,4 +30,5 @@
   [90m─[39m
 
   [32m4 tests passed[39m
+  [31m5 tests remained pending after a timeout[39m
 ---tty-stream-chunk-separator
diff --git a/test-tap/reporters/default.timeoutinmultiplefiles.v16.log b/test-tap/reporters/default.timeoutinmultiplefiles.v16.log
@@ -30,4 +30,5 @@
   [90m─[39m
 
   [32m4 tests passed[39m
+  [31m5 tests remained pending after a timeout[39m
 ---tty-stream-chunk-separator
diff --git a/test-tap/reporters/default.timeoutinmultiplefiles.v17.log b/test-tap/reporters/default.timeoutinmultiplefiles.v17.log
@@ -30,4 +30,5 @@
   [90m─[39m
 
   [32m4 tests passed[39m
+  [31m5 tests remained pending after a timeout[39m
 ---tty-stream-chunk-separator
diff --git a/test-tap/reporters/default.timeoutinsinglefile.v12.log b/test-tap/reporters/default.timeoutinsinglefile.v12.log
@@ -16,4 +16,5 @@
   [90m─[39m
 
   [32m2 tests passed[39m
+  [31m2 tests remained pending after a timeout[39m
 ---tty-stream-chunk-separator
diff --git a/test-tap/reporters/default.timeoutinsinglefile.v14.log b/test-tap/reporters/default.timeoutinsinglefile.v14.log
@@ -16,4 +16,5 @@
   [90m─[39m
 
   [32m2 tests passed[39m
+  [31m2 tests remained pending after a timeout[39m
 ---tty-stream-chunk-separator
diff --git a/test-tap/reporters/default.timeoutinsinglefile.v16.log b/test-tap/reporters/default.timeoutinsinglefile.v16.log
@@ -16,4 +16,5 @@
   [90m─[39m
 
   [32m2 tests passed[39m
+  [31m2 tests remained pending after a timeout[39m
 ---tty-stream-chunk-separator
diff --git a/test-tap/reporters/default.timeoutinsinglefile.v17.log b/test-tap/reporters/default.timeoutinsinglefile.v17.log
@@ -16,4 +16,5 @@
   [90m─[39m
 
   [32m2 tests passed[39m
+  [31m2 tests remained pending after a timeout[39m
 ---tty-stream-chunk-separator
diff --git a/test-tap/reporters/default.timeoutwithmatch.v12.log b/test-tap/reporters/default.timeoutwithmatch.v12.log
@@ -14,4 +14,5 @@
   [90m─[39m
 
   [32m1 test passed[39m
+  [31m2 tests remained pending after a timeout[39m
 ---tty-stream-chunk-separator
diff --git a/test-tap/reporters/default.timeoutwithmatch.v14.log b/test-tap/reporters/default.timeoutwithmatch.v14.log
@@ -14,4 +14,5 @@
   [90m─[39m
 
   [32m1 test passed[39m
+  [31m2 tests remained pending after a timeout[39m
 ---tty-stream-chunk-separator
diff --git a/test-tap/reporters/default.timeoutwithmatch.v16.log b/test-tap/reporters/default.timeoutwithmatch.v16.log
@@ -14,4 +14,5 @@
   [90m─[39m
 
   [32m1 test passed[39m
+  [31m2 tests remained pending after a timeout[39m
 ---tty-stream-chunk-separator
diff --git a/test-tap/reporters/default.timeoutwithmatch.v17.log b/test-tap/reporters/default.timeoutwithmatch.v17.log
@@ -14,4 +14,5 @@
   [90m─[39m
 
   [32m1 test passed[39m
+  [31m2 tests remained pending after a timeout[39m
 ---tty-stream-chunk-separator

Original file line number	Diff line number	Diff line change
`@@ -660,6 +660,10 @@ export default class Reporter {`
`660`	`660`	this.lineWriter.writeLine(colors.error(`${this.stats.uncaughtExceptions} uncaught ${plur('exception', this.stats.uncaughtExceptions)}`));
`661`	`661`	`}`
`662`	`662`
	`663`	`+ if (this.stats.timeouts > 0) {`
	`664`	+ this.lineWriter.writeLine(colors.error(`${this.stats.timeouts} ${plur('test', this.stats.timeouts)} remained pending after a timeout`));
	`665`	`+ }`
	`666`	`+`
`663`	`667`	`if (this.previousFailures > 0) {`
`664`	`668`	this.lineWriter.writeLine(colors.error(`${this.previousFailures} previous ${plur('failure', this.previousFailures)} in test files that were not rerun`));
`665`	`669`	`}`
-Original file line number
+Diff line change
   [90m─[39m
   [32m4 tests passed[39m
 +  [31m5 tests remained pending after a timeout[39m
 ---tty-stream-chunk-separator