Skip to content

Commit 4d95e28

Browse files
authored
Remove handling of isSource classification
* Remove documentation for unsupported 'sources' patterns in no-ignored-test-files rule * Remove handling of isSource classification This is being removed from AVA 3.
1 parent 5b34901 commit 4d95e28

File tree

4 files changed

+10
-13
lines changed

4 files changed

+10
-13
lines changed

docs/rules/no-ignored-test-files.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ This rule supports the following options:
4444
* `extensions`: an array of extensions of the files that AVA recognizes as test files or helpers. Overrides *both* the `babel.extensions` *and* `extensions` configuration otherwise used by AVA itself.
4545
* `files`: an array of glob patterns to select test files. Overrides the `files` configuration otherwise used by AVA itself.
4646
* `helpers`: an array of glob patterns to select helper files. Overrides the `helpers` configuration otherwise used by AVA itself.
47-
* `sources`: an array of glob patterns to match files that, when changed, cause tests to be re-run (when in watch mode). Overrides the `sources` configuration otherwise used by AVA itself.
4847

4948
See also [AVA's configuration](https://github.com/avajs/ava/blob/master/docs/06-configuration.md#options).
5049

rules/no-ignored-test-files.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,11 @@ const create = context => {
3131
return {};
3232
}
3333

34-
const {isHelper, isSource, isTest} = avaHelper.classifyFile(filename);
34+
const {isHelper, isTest} = avaHelper.classifyFile(filename);
3535

3636
if (!isTest) {
3737
if (isHelper) {
3838
context.report({node, message: 'AVA treats this as a helper file.'});
39-
} else if (isSource) {
40-
context.report({node, message: 'AVA treats this as a source file.'});
4139
} else {
4240
context.report({node, message: 'AVA ignores this file.'});
4341
}

test/no-ignored-test-files.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ util.loadAvaHelper = () => ({
2020
classifyFile: file => {
2121
switch (file) {
2222
case toPath('lib/foo.test.js'):
23-
return {isHelper: false, isSource: false, isTest: true};
23+
return {isHelper: false, isTest: true};
2424
case toPath('lib/foo/fixtures/bar.test.js'):
25-
return {isHelper: false, isSource: true, isTest: false};
25+
return {isHelper: false, isTest: false};
2626
case toPath('lib/foo/helpers/bar.test.js'):
27-
return {isHelper: true, isSource: false, isTest: false};
27+
return {isHelper: true, isTest: false};
2828
default:
29-
return {isHelper: false, isSource: false, isTest: false};
29+
return {isHelper: false, isTest: false};
3030
}
3131
}
3232
});
@@ -42,7 +42,7 @@ ruleTester.run('no-ignored-test-files', rule, {
4242
{
4343
code: code(true),
4444
filename: toPath('lib/foo/fixtures/bar.test.js'),
45-
errors: [{message: 'AVA treats this as a source file.'}]
45+
errors: [{message: 'AVA ignores this file.'}]
4646
},
4747
{
4848
code: code(true),

test/no-import-test-files.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ util.loadAvaHelper = () => ({
2020
classifyImport: importPath => {
2121
switch (importPath) {
2222
case toPath('lib/foo.test.js'):
23-
return {isHelper: false, isSource: false, isTest: true};
23+
return {isHelper: false, isTest: true};
2424
case toPath('../foo.test.js'):
25-
return {isHelper: false, isSource: false, isTest: true};
25+
return {isHelper: false, isTest: true};
2626
case toPath('@foo/bar'): // Regression test for https://github.com/avajs/eslint-plugin-ava/issues/253
27-
return {isHelper: false, isSource: false, isTest: true};
27+
return {isHelper: false, isTest: true};
2828
default:
29-
return {isHelper: false, isSource: false, isTest: false};
29+
return {isHelper: false, isTest: false};
3030
}
3131
}
3232
});

0 commit comments

Comments
 (0)