Fix no-identical-title when there is no title

novemberborn · novemberborn · commit cf361f196a19 · 2021-09-18T18:50:30.000+02:00
Fixes #317.
diff --git a/rules/no-identical-title.js b/rules/no-identical-title.js
@@ -32,7 +32,7 @@ const create = context => {
 			const titleNode = args.length > 1 || ava.hasTestModifier('todo') ? args[0] : undefined;
 
 			// Don't flag computed titles
-			if (!isStatic(titleNode)) {
+			if (!titleNode || !isStatic(titleNode)) {
 				return;
 			}
 
diff --git a/test/no-identical-title.js b/test/no-identical-title.js
@@ -33,6 +33,7 @@ ruleTester.run('no-identical-title', rule, {
 		` ${header}
 			const macro = (t, value) => { t.true(value); };
 
+			test(macro, true);
 			test('should work', macro, true);
 			test('should fail', macro, false);
 		`,

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ const create = context => {`
`32`	`32`	`const titleNode = args.length > 1 \|\| ava.hasTestModifier('todo') ? args[0] : undefined;`
`33`	`33`
`34`	`34`	`// Don't flag computed titles`
`35`		`- if (!isStatic(titleNode)) {`
	`35`	`+ if (!titleNode \|\| !isStatic(titleNode)) {`
`36`	`36`	`return;`
`37`	`37`	`}`
`38`	`38`