fix cache of GeneratorErrorReport (#242)

Author: aviatesk

src/JET.jl

@@ -966,7 +966,8 @@ function (::SoundBasicPass)(::Type{GeneratorErrorReport}, analyzer::AbstractAnal
             ccall(:jl_code_for_staged, Any, (Any,), mi)
         catch err
             # if user code throws error, wrap and report it
-            add_new_report!(GeneratorErrorReport(analyzer, mi, err), analyzer)
+            report = add_new_report!(GeneratorErrorReport(analyzer, mi, err), analyzer)
+            push!(get_to_be_updated(analyzer), report)
         end
     end
 end

test/test_abstractinterpretation.jl

@@ -911,28 +911,34 @@ end
             end
             throw("invalid argument")
         end
+
+        bar(args...) = foo(args...)
     end
 
-    # successful code generation, valid code
-    let
+    let # successful code generation, valid code
         analyzer, = report_call(m.foo, (Int,))
         @test isempty(get_reports(analyzer))
     end
 
-    # successful code generation, invalid code
-    let
+    let # successful code generation, invalid code
         analyzer, = report_call(m.foo, (Float64,))
         @test length(get_reports(analyzer)) == 1
         r = first(get_reports(analyzer))
         @test isa(r, GlobalUndefVarErrorReport)
         @test r.name === :undefvar
     end
 
-    # unsuccessful code generation
-    let
+    let # unsuccessful code generation
         analyzer, = report_call(m.foo, (String,))
         @test length(get_reports(analyzer)) == 1
         r = first(get_reports(analyzer))
         @test isa(r, GeneratorErrorReport) && r.err == "invalid argument"
     end
+
+    let # should work if cached
+        analyzer, = report_call(m.bar, (String,))
+        @test length(get_reports(analyzer)) == 1
+        r = first(get_reports(analyzer))
+        @test isa(r, GeneratorErrorReport) && r.err == "invalid argument"
+    end
 end