Merge pull request #1458 from aryanrai2001/Photo-To-Ascii-Improvements

Fixed bugs and improved output resolution

Author: avinashkranjan

Photo To Ascii/README.md

@@ -1,17 +1,17 @@
 
-<h1 align="center"> Photo to Ascii</h1>
-Convert your photo to ascii with it
+<h1 align="center">Photo to Ascii</h1>
+Convert your image to ASCII art using this simple python script!
 
----------------------------------------------------------------------
+---
 
 ## Modules Used
 - pillow
 
-
 ## How it works
--  First you have to enter the correct path where your photp is located.
-- Then it will  resize your photo and grayify it
-- Then it will convert your photo to ascii
-- Then you could find your photo in {image_name}(ASCII).txt file  where image_name is the name of your photo
+- First you have to enter the correct path where your image is located.
+- Then it will resize your image and grayify it.
+- Then it will convert your image to ascii.
+- Then it will save the ascii art to the file {imageFile-name}_{imageFile-extension}_ASCII.txt, located in the same folder as your image.
 
-#### By [Avishake Maji](https://github.com/Avishake007) 
+#### Created By [Avishake Maji](https://github.com/Avishake007)
+#### Improved By [Aryan Rai](https://github.com/aryanrai2001)

Photo To Ascii/photo_to_ascii.py

@@ -1,62 +1,49 @@
 from PIL import Image
 
-# ascii characters used to build the output text
+# ASCII characters used to build the output text
 CHARS = [".", ".", ".", "1", "1", "1", "1", "1", "0", "0", "0"]
-# convert each pixel to grayscale
-
-
-def grayify(image):
-    grayscale_image = image.convert("L")
-    return(grayscale_image)
-
-# convert pixels to a string of ascii characters
-
 
+# Convert pixels to a string of ASCII characters
 def pixels_to_ascii(image):
-    pixels = image.getdata()
-    characters = "".join([CHARS[pixel//23] for pixel in pixels])
+    pixels = image.convert("L").getdata()
+    characters = " ".join([CHARS[int((pixel/256)*len(CHARS))] for pixel in pixels])
     return(characters)
 
-
 def photoascii():
-
-    # attempt to open image from user-input
+    # Attempt to open image file from user-input
     path = input("Enter a valid pathname to an image:\n")
     try:
         image = Image.open(path)
     except Exception:
         print("Invalid path")
         return
-    # Fetching the name of the image
-    image_name = ""
-    flag = 0
-    for i in path[::-1]:
-        if i == "/":
-            break
-        if flag == 1:
-            image_name = i+image_name
-        if i == '.':
-            flag = 1
-
-    # Resizing of image
+
+    # Fetch the name of the image file
+    dot_index = path.rfind('.')
+    slash_index = path.rfind('\\')
+    if slash_index == -1:
+        slash_index = path.rfind('/')
+    image_name = path[slash_index+1:dot_index] + "_" + path[dot_index+1:]
+
+    # Resize image
     new_width = 100
     width, height = image.size
     ratio = height/width
     new_height = int(new_width * ratio)
     resized_image = image.resize((new_width, new_height))
 
-    # convert image to ascii
-    new_image_data = pixels_to_ascii(grayify(resized_image))
-
+    # Convert image to ASCII
+    new_image_data = pixels_to_ascii(resized_image)
     pixel_count = len(new_image_data)
-    ascii_image = "\n".join([new_image_data[index:(index+new_width)]
-                            for index in range(0, pixel_count, new_width)])
+    scanline_width = new_width * 2;
+    ascii_image = "\n".join([new_image_data[index:(index+scanline_width)]
+                            for index in range(0, pixel_count, scanline_width)])
 
-    # save result to "ascii_image.txt"
-    with open("./Photo To Ascii/{}(ASCII).txt".format(image_name), "w") as f:
+    # Save result to text file
+    with open(path[:slash_index] + "/{}_ASCII.txt".format(image_name), "w") as f:
         f.write(ascii_image)
 
 
-# run program
+# Run Program
 if __name__ == '__main__':
     photoascii()