try to fix root._write

Author: milahu

serialize_py/kaitai_serialize_codegen.py

@@ -38,7 +38,6 @@ def __getitem__(self, i):  # i is 0-based
         ), f"page index is out of range: {i} is not in (0, {header.num_pages - 1})"
         # todo: maybe cache page
         # equality test: page_a.page_number == page_b.page_number
-        # FIXME handle root page: i == 0
         _pos = root._io.pos()
         if i == 0:
             # The first 100 bytes of the database file comprise the database file header
@@ -176,15 +175,15 @@ def get_local_key(key, global_names):
 root = kaitaistruct_sqlite3.Sqlite3.from_bytes(good_database_header_bytes)
 
 # patch the internal cache attribute of root.pages
-# root._m_pages = PagesList(root)
+root._m_pages = PagesList(root)
 
 root._read()
 
 # print("root.header.magic", root.header.magic)
 # now, this will parse **only** the first page
 # fix: 'BtreePage' object has no attribute 'cell_pointers'
 
-if 1:
+if 0:
     # print("root.pages[0] keys:", get_keys(root.pages[0]))
     # print("root.pages[0] seq:", get_seq(root.pages[0]))
     # FIXME kaitaistruct.ValidationNotEqualError: /types/database_header/seq/0: at pos 116: validation failed: not equal,
@@ -198,7 +197,7 @@ def get_local_key(key, global_names):
     print_value("root.pages[0].num_cells")
     print_value("root.pages[0].cell_pointers[0]")
     print_value("root.pages[0].cell_pointers[0].ofs_content")
-if 1:
+if 0:
     # print("root.pages[1] keys:", get_keys(root.pages[1]))
     # print("root.pages[1] seq:", get_seq(root.pages[1]))
     print("root.pages[1]._read()"); root.pages[1]._read()
@@ -309,6 +308,10 @@ def codegen(
         print(f"{ind}{ids}if not _io:", file=out)
         print(f"{ind}{ids}{ids}_io = kaitaistruct.KaitaiStream(io.BytesIO(bytearray(root_size)))", file=out)
         print(f"{ind}{ids}{on} = {mod}.{member}(_io)", file=out)
+        # TODO remove. this works only for sqlite3.ksy
+        print(f"{ind}{ids}# try to fix root._write", file=out)
+        print(f"{ind}{ids}# https://github.com/kaitai-io/kaitai_struct/issues/1245", file=out)
+        print(f"{ind}{ids}{on}.pages__to_write = False", file=out)
     # else:
     #     print(f"{ind}{ids}# non-root init", file=out)
     #     print(f"{ind}{ids}{on} = {mod}.{member}(_io, {on_parent}, {on_parent}._root)", file=out)
@@ -423,11 +426,13 @@ def codegen(
         print(f"{ind}{ids}root = get_root()", file=out)
         print(f"{ind}{ids}_io = root._io", file=out)
         # print(f"{ind}{ids}_io.seek(0)", file=out)
-        print(f"{ind}{ids}# no. _write calls _fetch_instances which throws", file=out)
-        print(f"{ind}{ids}# root._write(_io)", file=out)
-        print(f"{ind}{ids}root._write__seq(_io)", file=out)
-        print(f"{ind}{ids}# root._fetch_instances() # this would throw", file=out)
-        print(f"{ind}{ids}root._io.write_back_child_streams()", file=out)
+        print(f"{ind}{ids}if 1:", file=out)
+        print(f"{ind}{ids}{ids}# no. _write calls _fetch_instances which throws", file=out)
+        print(f"{ind}{ids}{ids}root._write(_io)", file=out)
+        print(f"{ind}{ids}else:", file=out)
+        print(f"{ind}{ids}{ids}root._write__seq(_io)", file=out)
+        print(f"{ind}{ids}{ids}# root._fetch_instances() # this would throw", file=out)
+        print(f"{ind}{ids}{ids}root._io.write_back_child_streams()", file=out)
         print(f"{ind}{ids}return _io", file=out)
         print("", file=out)
         print(f"{ind}def get_bytes():", file=out)

serialize_py/kaitai_serialize_manual.py

@@ -75,7 +75,7 @@ def write(on):
 # FIXME add extra space for database header
 _io = kaitaistruct.KaitaiStream(io.BytesIO(bytearray(num_pages * page_size + 100)))
 
-if 0:
+if 1:
     root = kaitaistruct_sqlite3.Sqlite3(_io)
 else:
     class PatchedSqlite3(kaitaistruct_sqlite3.Sqlite3):
@@ -167,6 +167,11 @@ def _write(self, io=None):
 root.pages = []
 # page = set_value("root.header.root_page", root.BtreePage(page_number))
 page = root.BtreePage(page_number)
+
+# try to fix root._write
+# https://github.com/kaitai-io/kaitai_struct/issues/1245
+page.cell_content_area__to_write = False
+
 root.pages.append(page)
 page.database_header = root.header
 page._root = root
@@ -362,11 +367,18 @@ def _write(self, io=None):
 
 
 
+# try to fix root._write
+# https://github.com/kaitai-io/kaitai_struct/issues/1245
+root.pages__to_write = False
+
 _io.seek(0) # fix: _write__seq does not seek before writing
 
-# no. _write calls _fetch_instances which throws
-# print(f"writing root"); root._write(_io)
-print(f"writing root"); root._write__seq(_io); root._io.write_back_child_streams()
+if 1:
+  # no. _write calls _fetch_instances which throws
+  # https://github.com/kaitai-io/kaitai_struct/issues/1245
+  print(f"writing root"); root._write(_io)
+else:
+  print(f"writing root"); root._write__seq(_io); root._io.write_back_child_streams()
 
 print("writing done")