Significant speedup for YUV/NV12/P010 and related codecs

Log: replace old C-style format with modern C++20 for compile-time safety

Author: awawa-dev

.clang-tidy

@@ -0,0 +1,49 @@
+Checks: >
+  -*,
+  clang-analyzer-*,
+  modernize-*,
+  performance-*,
+  -cppcoreguidelines-pro-type-reinterpret-cast,
+  -cppcoreguidelines-pro-type-union-access,
+  -cppcoreguidelines-pro-bounds-constant-array-index,
+  -cppcoreguidelines-pro-bounds-pointer-arithmetic,
+  -cppcoreguidelines-owning-memory,
+  -cppcoreguidelines-no-malloc,
+  -cppcoreguidelines-avoid-magic-numbers,
+  -cppcoreguidelines-pro-type-vararg,
+  -cppcoreguidelines-avoid-non-const-global-variables,
+  -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
+  -clang-analyzer-security.insecureAPI.memcpy,
+  -fuchsia-trailing-return,
+  -modernize-use-trailing-return-type,
+  -modernize-use-auto,
+  -modernize-raw-string-literal,
+  -cppcoreguidelines-pro-type-cstyle-cast,
+  -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
+  -cppcoreguidelines-avoid-c-arrays,
+  -cppcoreguidelines-pro-type-member-init,
+  -cppcoreguidelines-macro-usage,
+  -modernize-avoid-c-arrays,
+  -performance-no-int-to-ptr,
+  -clang-analyzer-optin.core.EnumCastOutOfRange,
+  -clang-analyzer-core.UndefinedBinaryOperatorResult,
+  -modernize-use-default-member-init,
+  -cppcoreguidelines-narrowing-conversions,
+  -modernize-return-braced-init-list,
+  -performance-avoid-endl,
+  -modernize-loop-convert,
+  -clang-analyzer-security.FloatLoopCounter,
+  -modernize-use-emplace,
+  -modernize-macro-to-enum,
+  -performance-enum-size
+
+CheckOptions:
+  - key:             performance-unnecessary-value-param.AllowedTypes
+    value:           ^Q[A-Z].*$
+  - key:             performance-unnecessary-copy-initialization.AllowedTypes
+    value:           ^Q[A-Z].*$
+  - key:             cppcoreguidelines-macro-usage.AllowedRegexp
+    value:           ^DEBUG_*$
+
+HeaderFilterRegex: '^(?!.*(autogen|mocs_|qrc_|/external/|_deps/)).*'
+

.clang-tidy-fix

@@ -0,0 +1,44 @@
+Checks: >
+  -*,
+  modernize-use-nullptr,
+  modernize-use-override,
+  modernize-use-equals-default,
+  modernize-use-equals-delete,
+  modernize-use-bool-literals,
+  modernize-deprecated-headers,
+  performance-faster-string-find,
+  performance-for-range-copy,
+  performance-inefficient-vector-operation,
+  readability-container-size-empty,
+  readability-redundant-string-cstr,
+  readability-string-compare,
+  bugprone-copy-constructor-init,  
+  bugprone-macro-parentheses,
+  readability-redundant-smartptr-get,
+  readability-redundant-control-flow,
+  readability-static-accessed-through-instance,
+  performance-move-const-arg,
+  modernize-make-unique,
+  readability-simplify-boolean-expr,
+  modernize-redundant-void-arg,  
+  readability-redundant-casting,
+  readability-inconsistent-declaration-parameter-name,
+  performance-unnecessary-value-param,
+  performance-unnecessary-copy-initialization
+
+CheckOptions:
+  - key:             performance-unnecessary-value-param.AllowedTypes
+    value:           '.*Q[A-Z].*'
+  - key:             performance-unnecessary-copy-initialization.AllowedTypes
+    value:           '.*Q[A-Z].*'
+
+HeaderFilterRegex: '^(?!.*(autogen|mocs_|qrc_|/external/|_deps/)).*'
+
+#Checks: >
+#  -*,
+#  readability-duplicate-include
+#
+#ExtraArgs:
+#  - "-include"
+#  - "include/precompiled_hyperhdr_headers/AllHeaders_pch.h"
+#  - "-DPCH_ENABLED"

.clazy

@@ -0,0 +1,12 @@
+Checks=level1,level2,\
+container-inside-loop,\
+detaching-member,\
+inefficient-qlist,\
+missing-qobject-macro,\
+qstring-allocations,\
+qt4-qstring-from-array,\
+no-qstring-arg,\
+range-loop,\
+missing-type-info,\
+no-autodetect,\
+no-skipped-base-method

.github/workflows/push-master.yml

@@ -321,12 +321,12 @@ jobs:
 
       - name: Run clazy
         run: |
-          jq -r '.[] | select((.file | type=="string") and (.file | test("^(external/|_deps/)") | not)) | .file' build/compile_commands.json | xargs clazy-standalone -p build -- > clazy-report.txt 2>&1 || true
+          jq -r '.[] | .file' build/compile_commands.json | tr '\n' '\0' | xargs -0 clazy-standalone -p build -ignore-dirs "/external/|_deps/" 2>&1 | sed "/warning: argument unused during compilation: '-fuse-ld=gold'/d; /\[-Wclazy-const-signal-or-slot\]/,/^[[:space:]]*\^/d; /\[-Wclazy-qstring-arg\]/,/^[[:space:]]*\^/d; /\[-Wclazy-skipped-base-method\]/,/^[[:space:]]*\^/d" | sed '/^In file included from/d; /^[0-9]\+ warning.* generated\./d' > clazy-report.txt || true
 
       - name: Run clang-tidy
         run: |
-          jq -r '.[] | select(.file | test("external/") | not and test("_deps/") | not) | .file' build/compile_commands.json | xargs run-clang-tidy -p build > clang-tidy-report.txt || true
-
+          jq -r '.[] | select(.file | test("external/|_deps/|/mocs_") | not) | .file' build/compile_commands.json | xargs run-clang-tidy -p build -quiet | awk 'BEGIN{b=""}/: warning:/{if(b!=""&&!s)printf"%s",b;b="";s=0;c=$0~/(pass-by-value|value-param)/;l="";nx=0}{b=b$0"\n";if(c){if(nx){if(substr($0,idx)~/^Q[A-Z][a-zA-Z0-9]*/)s=1;nx=0}if($0~/^[ \t]*\|?[ \t]*\^/){idx=index($0,"^");if(substr(l,idx)~/^(const[ \t]+)?Q[A-Z][a-zA-Z0-9]*/)s=1;nx=1}if($0~/^[ \t]*[0-9]+ \|/)l=$0}}END{if(b!=""&&!s)printf"%s",b}' > clang-tidy-report.txt || true
+#          jq -r '.[] | select(.file | test("external/|_deps/|autogen|mocs_|qrc_") | not) | .file' build/compile_commands.json | xargs run-clang-tidy -p build -quiet -config="$(cat .clang-tidy-fix)" -fix > clang-tidy-fix.log 2>&1 || true
       - name: Combine reports
         run: |
           echo "### Clang-Tidy Report" > report.md

.gitignore

@@ -25,6 +25,8 @@ build/
 include/flatbuffers/parser/hyperhdr_reply_generated.h
 include/flatbuffers/parser/hyperhdr_request_generated.h
 
+tests/codec_test/build/
+
 
 # Kdevelop project files
 *.kdev*

CMakeLists.txt

@@ -602,20 +602,16 @@ else()
 endif()
 message(STATUS "C++20 support has been enabled.")
 
-# Use lld then ld.gold linker if available
-if((CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang") AND NOT WIN32 AND NOT APPLE)
-	find_program(LLD_EXECUTABLE lld)
-	find_program(GOLD_EXECUTABLE ld.gold)
-
-	if(LLD_EXECUTABLE)
-		message(STATUS "Found 'lld' linker, enabling...")
-		add_compile_options("-fuse-ld=lld")
-	elseif(GOLD_EXECUTABLE)
-		message(STATUS "Found 'gold' linker, enabling...")
-		add_compile_options("-fuse-ld=gold")
-	else()
-		message(STATUS "Using default system linker (lld and gold not found).")
-	endif()
+# Use lld linker if available
+if((CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang") AND NOT WIN32 AND NOT APPLE)
+    find_program(LLD_EXECUTABLE ld.lld)
+
+    if(LLD_EXECUTABLE)
+        message(STATUS "Found 'lld' linker, enabling...")
+        add_link_options("-fuse-ld=lld")
+    else()
+        message(STATUS "Using default system linker (ld.lld not found).")
+    endif()
 endif()
 
 # Don't create new dynamic tags (RUNPATH)

include/api/BaseAPI.h

@@ -19,7 +19,7 @@ class BaseAPI : public QObject
 	Q_OBJECT
 
 public:
-	BaseAPI(Logger* log, bool localConnection, QObject* parent);
+	BaseAPI(const LoggerName& log, bool localConnection, QObject* parent);
 
 	struct ImageCmdData
 	{
@@ -118,7 +118,7 @@ class BaseAPI : public QObject
 
 	bool _adminAuthorized;
 
-	Logger* _log;
+	LoggerName _log;
 	std::shared_ptr<HyperHdrManager>	_instanceManager;
 	std::shared_ptr<AccessManager>		_accessManager;	
 	std::shared_ptr<HyperHdrInstance>	_hyperhdr;

include/api/CallbackAPI.h

@@ -28,7 +28,7 @@ class CallbackAPI : public BaseAPI
 	Q_OBJECT
 
 public:
-	CallbackAPI(Logger* log, bool localConnection, QObject* parent);
+	CallbackAPI(const LoggerName& log, bool localConnection, QObject* parent);
 
 	void subscribe(QJsonArray subsArr);
 
@@ -38,7 +38,7 @@ class CallbackAPI : public BaseAPI
 	void stopDataConnections() override = 0;
 	void removeSubscriptions() override;
 	void addSubscriptions() override;
-	bool subscribeFor(const QString& cmd, bool unsubscribe = false);
+	bool subscribeFor(const QString& type, bool unsubscribe = false);
 
 signals:
 	void SignalCallbackToClient(QJsonObject);

include/api/HyperAPI.h

@@ -19,7 +19,7 @@ class HyperAPI : public CallbackAPI
 	Q_OBJECT
 
 public:
-	HyperAPI(QString peerAddress, Logger* log, bool localConnection, QObject* parent, bool noListener = false);
+	HyperAPI(QString peerAddress, const LoggerName& log, bool localConnection, QObject* parent, bool noListener = false);
 	void handleMessage(const QString& message, const QString& httpAuthHeader = "");
 	void initialize();
 
@@ -31,7 +31,7 @@ public slots:
 private slots:
 	void newPendingTokenRequest(const QString& id, const QString& comment);
 	void handleTokenResponse(bool success, const QString& token, const QString& comment, const QString& id, const int& tan);
-	void handleInstanceStateChange(InstanceState state, quint8 instance, const QString& name = QString());	
+	void handleInstanceStateChange(hyperhdr::InstanceState state, quint8 instance, const QString& name = QString());
 	void handleLedColorsTimer();
 	void lutDownloaded(QNetworkReply* reply, int hardware_brightness, int hardware_contrast, int hardware_saturation, qint64 time);
 

include/base/AccessManager.h

@@ -3,8 +3,8 @@
 #ifndef PCH_ENABLED
 	#include <QMap>
 	#include <QVector>
+	#include <vector>
 #endif
-
 #include <utils/Logger.h>
 #include <utils/settings.h>
 
@@ -80,8 +80,8 @@ public slots:
 	bool _localAdminAuthRequired;
 	QTimer* _timer;
 	QTimer* _authBlockTimer;
-	QVector<uint64_t> _userAuthAttempts;
-	QVector<uint64_t> _tokenAuthAttempts;
+	std::vector<uint64_t> _userAuthAttempts;
+	std::vector<uint64_t> _tokenAuthAttempts;
 
 private slots:
 	void checkTimeout();