Skip to content

Commit 83f5efb

Browse files
authored
Fix macOS 15 dark theme menu icons (#988)
1 parent 8d6032f commit 83f5efb

File tree

13 files changed

+41
-18
lines changed

13 files changed

+41
-18
lines changed

.github/workflows/push-master.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ jobs:
142142
matrix:
143143
include:
144144
- JOB_RUNNER: macos-14
145-
JOB_NAME: macOS 14 (arm64/M1/M2)
145+
JOB_NAME: macOS 14 (arm64 = M1/M2/M3/M4)
146146
QT_VERSION: 6
147147
NICE_NAME: arm64_M1_M2
148148
- JOB_RUNNER: macos-13

CMakeLists.txt

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -200,13 +200,10 @@ if ( "${PLATFORM}" MATCHES "osx" )
200200
if (CMAKE_OSX_DEPLOYMENT_TARGET)
201201
set(CMAKE_OSX_HYPERHDR_DEPLOYMENT_TARGET ${CMAKE_OSX_DEPLOYMENT_TARGET})
202202
else()
203-
set(VERSION_REPLACEMENT ${CMAKE_OSX_SYSROOT})
204-
string(REPLACE "/SDKs/MacOSX" "." VERSION_REPLACEMENT ${VERSION_REPLACEMENT})
205-
string(REPLACE "." ";" VERSION_REPLACEMENT_LIST ${VERSION_REPLACEMENT})
206-
list(LENGTH VERSION_REPLACEMENT_LIST VERSION_REPLACEMENT_LIST_LENGTH)
207-
if (${VERSION_REPLACEMENT_LIST_LENGTH} GREATER_EQUAL 1)
208-
list (GET VERSION_REPLACEMENT_LIST 1 CMAKE_OSX_HYPERHDR_DEPLOYMENT_TARGET)
209-
endif()
203+
string(REGEX MATCH "MacOSX([0-9]+)" _ ${CMAKE_OSX_SYSROOT})
204+
if (${CMAKE_MATCH_COUNT} EQUAL "1")
205+
set(CMAKE_OSX_HYPERHDR_DEPLOYMENT_TARGET ${CMAKE_MATCH_1})
206+
endif()
210207
endif(CMAKE_OSX_DEPLOYMENT_TARGET)
211208

212209
if (CMAKE_OSX_HYPERHDR_DEPLOYMENT_TARGET)

build.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ if [[ "$CI_NAME" == 'osx' || "$CI_NAME" == 'darwin' ]]; then
115115
if [[ $(uname -m) == 'arm64' ]]; then
116116
BUILD_OPTION=""
117117
else
118-
BUILD_OPTION="-DUSE_PRECOMPILED_HEADERS=OFF"
118+
BUILD_OPTION="-DUSE_PRECOMPILED_HEADERS=OFF -DCMAKE_OSX_DEPLOYMENT_TARGET=10.15"
119119
export CCACHE_COMPILERCHECK=content
120120
fi
121121
else
@@ -129,7 +129,7 @@ if [[ "$CI_NAME" == 'osx' || "$CI_NAME" == 'darwin' ]]; then
129129
ls -a build/.ccache
130130
cd build
131131
ccache -z -d ./.ccache || true
132-
cmake -DPLATFORM=${PLATFORM} ${BUILD_OPTION} -DCMAKE_BUILD_TYPE=${BUILD_TYPE} -DCMAKE_OSX_DEPLOYMENT_TARGET=10.15 -DCMAKE_INSTALL_PREFIX:PATH=/usr/local ../ || exit 2
132+
cmake -DPLATFORM=${PLATFORM} ${BUILD_OPTION} -DCMAKE_BUILD_TYPE=${BUILD_TYPE} -DCMAKE_INSTALL_PREFIX:PATH=/usr/local ../ || exit 2
133133
make -j $(sysctl -n hw.ncpu) || exit 3
134134
sudo cpack || exit 3
135135
ccache -sv -d ./.ccache || true

include/systray/Systray.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,10 @@ struct SystrayMenu
6666
void SystrayClose();
6767
#endif
6868

69+
#ifdef __APPLE__
70+
bool SystrayDarkmode();
71+
#endif
72+
6973
#ifdef _WIN32
7074
HWND SystrayGetWindow();
7175
#endif

resources/icons/autorun.svg

Lines changed: 1 addition & 1 deletion
Loading

resources/icons/clear.svg

Lines changed: 1 addition & 1 deletion
Loading

resources/icons/color.svg

Lines changed: 1 addition & 1 deletion
Loading

resources/icons/effects.svg

Lines changed: 1 addition & 1 deletion
Loading

resources/icons/instance.svg

Lines changed: 1 addition & 1 deletion
Loading

resources/icons/settings.svg

Lines changed: 2 additions & 2 deletions
Loading

0 commit comments

Comments
 (0)