Merge branch 'awesomeWM:master' into fix-firefox-fullscreen-stack

Author: Watkurem

.github/ISSUE_TEMPLATE/1-bug.yml

@@ -0,0 +1,72 @@
+# https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository
+# https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema
+name: Bug Report
+description: File a bug report.
+labels: ["bug", "triage"]
+projects: ["awesomeWM/awesome"]
+type: bug
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to fill out this bug report!
+  - type: textarea
+    id: what-happened
+    attributes:
+      label: How to reproduce the issue?
+      description: step-by-step instructions on what to do
+      placeholder: 1) ... 2) ... 3) PROFIT
+    validations:
+      required: true
+  - type: textarea
+    id: awesome-version-output
+    attributes:
+      label: "Output of `awesome --version`"
+      description: please use FULL command output, not version only
+      placeholder: paste it here
+    validations:
+      required: true
+  - type: textarea
+    id: result-actual
+    attributes:
+      label: Actual Result
+      placeholder: what happened
+    validations:
+      required: false
+  - type: textarea
+    id: result-expected
+    attributes:
+      label: Expected Result
+      placeholder: what should happen
+    validations:
+      required: false
+  - type: checkboxes
+    id: debug-config
+    attributes:
+      label: Default Config File
+      description: Can you reproduce the same issue with default config file
+      options:
+        - label: "I can reproduce the same problem with default `rc.lua` file"
+  - type: checkboxes
+    id: debug-argb
+    attributes:
+      label: ARGB mode
+      description: "If you experience visual glitches, have you tried running AwesomeWM with `--no-argb` flag."
+      options:
+        - label: "I experience visual glitches and tried running AwesomeWM in no-argb mode and still can reproduce the problem"
+  - type: textarea
+    # @TODO: add common steps for debugging and retrieve extra info from clients etc
+    id: logs
+    attributes:
+      label: Relevant log output
+      description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks.
+      render: shell
+    validations:
+      required: false
+  - type: upload
+    id: screenshots
+    attributes:
+      label: Upload screenshots
+      description: If applicable, add screenshots to help explain your problem.
+    validations:
+      required: false

.github/ISSUE_TEMPLATE/2-feature.yml

@@ -0,0 +1,25 @@
+# https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository
+# https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema
+name: Feature Request
+description: Propose a new feature.
+labels: ["feature", "triage"]
+projects: ["awesomeWM/awesome"]
+type: feature
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to fill out this feature request!
+  - type: textarea
+    id: what-happened
+    attributes:
+      label: Describe your idea
+    validations:
+      required: true
+  - type: upload
+    id: screenshots
+    attributes:
+      label: Upload screenshots
+      description: If applicable, add screenshots to help explain your idea.
+    validations:
+      required: false

ISSUE_TEMPLATE.md

@@ -123,7 +123,7 @@ awesome_atexit(bool restart)
     }
 
     /* Save the client order.  This is useful also for "hard" restarts. */
-    xcb_window_t *wins = p_alloca(xcb_window_t, globalconf.clients.len);
+    xcb_window_t wins[globalconf.clients.len];
     int n = 0;
     foreach(client, globalconf.clients)
         wins[n++] = (*client)->window;
@@ -568,7 +568,7 @@ true_config_callback(const char *unused)
 int
 main(int argc, char **argv)
 {
-    string_array_t searchpath;
+    string_array_t searchpath = {};
     int xfd;
     xdgHandle xdg;
     xcb_query_tree_cookie_t tree_c;
@@ -587,7 +587,6 @@ main(int argc, char **argv)
     globalconf.exit_code = EXIT_SUCCESS;
     globalconf.api_level = awesome_default_api_level();
     buffer_init(&globalconf.startup_errors);
-    string_array_init(&searchpath);
 
     /* save argv */
     awesome_argv = argv;
@@ -610,8 +609,8 @@ main(int argc, char **argv)
     for(; *xdgconfigdirs; xdgconfigdirs++)
     {
         /* Append /awesome to *xdgconfigdirs */
-        const char *suffix = "/awesome";
-        size_t len = a_strlen(*xdgconfigdirs) + a_strlen(suffix) + 1;
+        const char suffix[] = "/awesome";
+        size_t len = a_strlen(*xdgconfigdirs) + sizeof(suffix);
         char *entry = p_new(char, len);
         a_strcat(entry, len, *xdgconfigdirs);
         a_strcat(entry, len, suffix);

awesome.c

@@ -142,7 +142,7 @@
         pfx##_array_splice(arr, r, 0, &e, 1);                               \
     }                                                                       \
     static inline void                                                      \
-    pfx##_array_inserts(pfx##_array_t *arr, type_t items[], int count)      \
+    pfx##_array_inserts(pfx##_array_t *arr, const type_t items[], int count)\
     {                                                                       \
         pfx##_array_growx(arr, arr->len + count);                           \
         memcpy(arr->tab + arr->len, items, count * sizeof(*items));         \

common/array.h

@@ -155,8 +155,8 @@ luaA_class_add_property(lua_class_t *lua_class,
 
 void
 luaA_class_add_properties(lua_class_t* lua_class,
-                          lua_class_property_t properties[],
-                          size_t count)
+                          const lua_class_property_t properties[],
+                          int count)
 {
     lua_class_property_array_inserts(&lua_class->properties, properties, count);
 }
@@ -302,7 +302,7 @@ luaA_class_connect_signal_from_stack(lua_State *L, lua_class_t *lua_class,
     /* Duplicate the function in the stack */
     lua_pushvalue(L, ud);
 
-    char *buf = p_alloca(char, a_strlen(name) + a_strlen(CONNECTED_SUFFIX) + 1);
+    char buf[a_strlen(name) + a_strlen(CONNECTED_SUFFIX) + 1];
 
     /* Create a new signal to notify there is a global connection. */
     sprintf(buf, "%s%s", name, CONNECTED_SUFFIX);

common/luaclass.c

@@ -108,7 +108,7 @@ void luaA_class_setup(lua_State *, lua_class_t *, const char *, lua_class_t *,
 
 void luaA_class_add_property(lua_class_t *, const char *,
                              lua_class_propfunc_t, lua_class_propfunc_t, lua_class_propfunc_t);
-void luaA_class_add_properties(lua_class_t *, lua_class_property_t[] , size_t);
+void luaA_class_add_properties(lua_class_t *, const lua_class_property_t[] , int);
 
 int luaA_usemetatable(lua_State *, int, int);
 int luaA_class_index(lua_State *);

common/luaclass.h

@@ -32,10 +32,6 @@
 #include <assert.h>
 #include <stdio.h>
 
-#if !(defined (__FreeBSD__) || defined(__OpenBSD__) || defined(__NetBSD__) || defined (__DragonFly__))
-#include <alloca.h>
-#endif
-
 /** \brief replace \c NULL strings with empty strings */
 #define NONULL(x)       (x ? x : "")
 
@@ -59,10 +55,6 @@
 #define fieldsizeof(type_t, m)  sizeof(((type_t *)0)->m)
 #define fieldtypeof(type_t, m)  typeof(((type_t *)0)->m)
 
-#define p_alloca(type, count)                                \
-        ((type *)memset(alloca(sizeof(type) * (count)),      \
-                        0, sizeof(type) * (count)))
-
 #define p_alloc_nr(x)           (((x) + 16) * 3 / 2)
 #define p_new(type, count)      ((type *)xmalloc(sizeof(type) * (count)))
 #define p_clear(p, count)       ((void)memset((p), 0, sizeof(*(p)) * (count)))

common/util.h

@@ -392,25 +392,25 @@ event_handle_configurerequest(xcb_configure_request_event_t *ev)
 
         /* Request the changes to be applied */
         luaA_object_push(L, c);
-        lua_pushstring(L, "ewmh");     /* context */
+        lua_pushliteral(L, "ewmh");     /* context */
         lua_newtable(L);               /* props */
 
         /* area, it needs to be directly in the `hints` table to comply with
            the "protocol"
          */
-        lua_pushstring(L, "x");
+        lua_pushliteral(L, "x");
         lua_pushinteger(L, geometry.x);
         lua_rawset(L, -3);
 
-        lua_pushstring(L, "y");
+        lua_pushliteral(L, "y");
         lua_pushinteger(L, geometry.y);
         lua_rawset(L, -3);
 
-        lua_pushstring(L, "width");
+        lua_pushliteral(L, "width");
         lua_pushinteger(L, geometry.width);
         lua_rawset(L, -3);
 
-        lua_pushstring(L, "height");
+        lua_pushliteral(L, "height");
         lua_pushinteger(L, geometry.height);
         lua_rawset(L, -3);
 
@@ -898,7 +898,6 @@ event_handle_randr_output_change_notify(xcb_randr_notify_event_t *ev)
     if(ev->subCode == XCB_RANDR_NOTIFY_OUTPUT_CHANGE) {
         xcb_randr_output_t output = ev->u.oc.output;
         uint8_t connection = ev->u.oc.connection;
-        const char *connection_str = NULL;
         xcb_randr_get_output_info_reply_t *info;
         lua_State *L = globalconf_get_lua_State();
 
@@ -914,20 +913,19 @@ event_handle_randr_output_change_notify(xcb_randr_notify_event_t *ev)
         if(!info)
             return;
 
-        switch(connection) {
-            case XCB_RANDR_CONNECTION_CONNECTED:
-                connection_str = "Connected";
-                break;
-            case XCB_RANDR_CONNECTION_DISCONNECTED:
-                connection_str = "Disconnected";
-                break;
-            default:
-                connection_str = "Unknown";
-                break;
+        lua_pushlstring(L, (char*)xcb_randr_get_output_info_name(info), xcb_randr_get_output_info_name_length(info));
+        switch (connection) {
+        case XCB_RANDR_CONNECTION_CONNECTED:
+            lua_pushliteral(L, "Connected");
+            break;
+        case XCB_RANDR_CONNECTION_DISCONNECTED:
+            lua_pushliteral(L, "Disconnected");
+            break;
+        default:
+            lua_pushliteral(L, "Unknown");
+            break;
         }
 
-        lua_pushlstring(L, (char *)xcb_randr_get_output_info_name(info), xcb_randr_get_output_info_name_length(info));
-        lua_pushstring(L, connection_str);
         signal_object_emit(L, &global_signals, "screen::change", 2);
 
         p_delete(&info);

event.c

@@ -94,7 +94,7 @@ ewmh_update_net_active_window(lua_State *L)
 static int
 ewmh_update_net_client_list(lua_State *L)
 {
-    xcb_window_t *wins = p_alloca(xcb_window_t, globalconf.clients.len);
+    xcb_window_t wins[globalconf.clients.len];
 
     int n = 0;
     foreach(client, globalconf.clients)
@@ -215,16 +215,16 @@ ewmh_update_maximize(bool h, bool status, bool toggle)
     lua_State *L = globalconf_get_lua_State();
 
     if (h)
-        lua_pushstring(L, "client_maximize_horizontal");
+        lua_pushliteral(L, "client_maximize_horizontal");
     else
-        lua_pushstring(L, "client_maximize_vertical");
+        lua_pushliteral(L, "client_maximize_vertical");
 
     /* Create table argument with raise=true. */
     lua_newtable(L);
-    lua_pushstring(L, "toggle");
+    lua_pushliteral(L, "toggle");
     lua_pushboolean(L, toggle);
     lua_settable(L, -3);
-    lua_pushstring(L, "status");
+    lua_pushliteral(L, "status");
     lua_pushboolean(L, status);
     lua_settable(L, -3);
 
@@ -271,7 +271,7 @@ void
 ewmh_update_net_client_list_stacking(void)
 {
     int n = 0;
-    xcb_window_t *wins = p_alloca(xcb_window_t, globalconf.stack.len);
+    xcb_window_t wins[globalconf.stack.len];
 
     foreach(client, globalconf.stack)
         wins[n++] = (*client)->window;
@@ -467,7 +467,7 @@ ewmh_process_client_message(xcb_client_message_event_t *ev)
         {
             lua_State *L = globalconf_get_lua_State();
             luaA_object_push(L, globalconf.tags.tab[idx]);
-            lua_pushstring(L, "ewmh");
+            lua_pushliteral(L, "ewmh");
             luaA_object_emit_signal(L, -2, "request::select", 1);
             lua_pop(L, 1);
         }
@@ -499,11 +499,11 @@ ewmh_process_client_message(xcb_client_message_event_t *ev)
         if((c = client_getbywin(ev->window))) {
             lua_State *L = globalconf_get_lua_State();
             luaA_object_push(L, c);
-            lua_pushstring(L, "ewmh");
+            lua_pushliteral(L, "ewmh");
 
             /* Create table argument with raise=true. */
             lua_newtable(L);
-            lua_pushstring(L, "raise");
+            lua_pushliteral(L, "raise");
             lua_pushboolean(L, true);
             lua_settable(L, -3);
 
@@ -768,10 +768,9 @@ static cairo_surface_array_t
 ewmh_window_icon_from_reply(xcb_get_property_reply_t *r)
 {
     uint32_t *data, *data_end;
-    cairo_surface_array_t result;
+    cairo_surface_array_t result = {};
     cairo_surface_t *s;
 
-    cairo_surface_array_init(&result);
     if(!r || r->type != XCB_ATOM_CARDINAL || r->format != 32)
         return result;