refactor(backtrace): delete buffer_t

Author: cnjhb

awesome.c

@@ -492,9 +492,8 @@ a_glib_poll(GPollFD *ufds, guint nfsd, gint timeout)
 static void
 signal_fatal(int signum)
 {
-    buffer_t buf;
-    backtrace_get(&buf);
-    fatal("signal %d, dumping backtrace\n%s", signum, buf.s);
+    GString* buf = backtrace_get();
+    fatal("signal %d, dumping backtrace\n%s", signum, buf->str);
 }
 
 /* Signal handler for SIGCHLD. Causes reap_children() to be called. */

common/backtrace.c

@@ -21,6 +21,7 @@
 
 #include "config.h"
 #include "common/backtrace.h"
+#include "common/util.h"
 
 #ifdef HAS_EXECINFO
 #include <execinfo.h>
@@ -31,11 +32,10 @@
 /** Get a backtrace.
   * \param buf The buffer to fill with backtrace.
   */
-void
-backtrace_get(buffer_t *buf)
+GString*
+backtrace_get(void)
 {
-    buffer_init(buf);
-
+    GString *buf = g_string_new(NULL);
 #ifdef HAS_EXECINFO
     void *stack[MAX_STACK_SIZE];
     char **bt;
@@ -49,14 +49,15 @@ backtrace_get(buffer_t *buf)
         for(int i = 0; i < stack_size; i++)
         {
             if(i > 0)
-                buffer_addsl(buf, "\n");
-            buffer_adds(buf, bt[i]);
+                g_string_append(buf, "\n");
+            g_string_append(buf, bt[i]);
         }
         p_delete(&bt);
     }
     else
 #endif
-        buffer_addsl(buf, "Cannot get backtrace symbols.");
+    g_string_append(buf, "Cannot get backtrace symbols.");
+    return buf;
 }
 
 // vim: filetype=c:expandtab:shiftwidth=4:tabstop=8:softtabstop=4:textwidth=80

common/backtrace.h

@@ -22,9 +22,9 @@
 #ifndef AWESOME_COMMON_BACKTRACE
 #define AWESOME_COMMON_BACKTRACE
 
-#include "common/buffer.h"
+#include <glib.h>
 
-void backtrace_get(buffer_t *);
+GString* backtrace_get(void);
 
 #endif
 

common/luaobject.c

@@ -125,9 +125,9 @@ luaA_object_decref(lua_State *L, int tud, const void *pointer)
     /* Did we find the item in our table? (tointeger(nil)-1) is -1 */
     if (count < 0)
     {
-        buffer_t buf;
-        backtrace_get(&buf);
-        warn("BUG: Reference not found: %d %p\n%s", tud, pointer, buf.s);
+        GString* buf = backtrace_get();
+        warn("BUG: Reference not found: %d %p\n%s", tud, pointer, buf->str);
+        g_string_free(buf, TRUE);
 
         /* Pop reference count and metatable */
         lua_pop(L, 2);

luaa.c

@@ -862,9 +862,8 @@ luaA_panic(lua_State *L)
 {
     warn("unprotected error in call to Lua API (%s)",
          lua_tostring(L, -1));
-    buffer_t buf;
-    backtrace_get(&buf);
-    warn("dumping backtrace\n%s", buf.s);
+    GString* buf = backtrace_get();
+    warn("dumping backtrace\n%s", buf->str);
     warn("restarting awesome");
     awesome_restart();
     return 0;