Notification Icon isn't replaced

[SethBarberee]

@Elv13, sorry I keep hitting you with naughty bugs 😄

Output of awesome --version:

awesome v4.3-350-ged091838 (Too long)
 • Compiled against Lua 5.3.5 (running with Lua 5.3)
 • D-Bus support: ✔
 • xcb-errors support: ✔
 • execinfo support: ✔
 • xcb-randr version: 1.6
 • LGI version: 0.9.2

How to reproduce the issue:

Trigger a new notification that uses icons (used spotify since it shows album art on each new song) during when the first notifcation is displayed. The text is replaced but icon is not replaced.

NOTE: When first notification is destroyed, the icon is properly set. This does not happen when the first notification is still displayed.

Actual result:

Album Art (Icon) from first notification is still there while text is updated.

Expected result:

Album art (icon) for the recent notification should be the icon and properly replace just like the text.

[SethBarberee]

This has been fixed so closing this for now

[actionless]

i still can reproduce it in a bit more limited test case:

if content of the image file changes
then setting notification.icon to the same filename doesn't update the icon

[elenapan]

if content of the image file changes then setting notification.icon to the same filename doesn't update the icon

As far as I know, imageboxes in general have this issue.

[psychon]

Should

awesome/lib/naughty/widget/icon.lua

Line 93 in 87928be

local icn = gsurface.load_silently(notif.icon)

and

awesome/lib/naughty/widget/icon.lua

Line 160 in 87928be

local icn = gsurface.load_silently(tb._private.notification.icon)

use load_uncached_silently?

[actionless]

mb cache should check the filesize, not only filename?

[psychon]

mtime would be more sensible than filesize, I think

[actionless]

yup