Merge pull request #153 from namsic/unlock-sasl_startup_state

m6w6 · web-flow · commit db71a075bec1 · 2025-08-19T10:45:46.000+02:00
Unlock mutex before return if `sasl_startup_function` fails
diff --git a/src/libmemcached/sasl.cc b/src/libmemcached/sasl.cc
@@ -180,6 +180,7 @@ memcached_return_t memcached_sasl_authenticate_connection(memcached_instance_st
   (void) pthread_mutex_lock(&sasl_startup_state_LOCK);
   if (sasl_startup_state != SASL_OK) {
     const char *sasl_error_msg = sasl_errstring(sasl_startup_state, NULL, NULL);
+    (void) pthread_mutex_unlock(&sasl_startup_state_LOCK);
     return memcached_set_error(*server, MEMCACHED_AUTH_PROBLEM, MEMCACHED_AT,
                                memcached_string_make_from_cstr(sasl_error_msg));
   }

Original file line number	Diff line number	Diff line change
`@@ -180,6 +180,7 @@ memcached_return_t memcached_sasl_authenticate_connection(memcached_instance_st`
`180`	`180`	`(void) pthread_mutex_lock(&sasl_startup_state_LOCK);`
`181`	`181`	`if (sasl_startup_state != SASL_OK) {`
`182`	`182`	`const char *sasl_error_msg = sasl_errstring(sasl_startup_state, NULL, NULL);`
	`183`	`+ (void) pthread_mutex_unlock(&sasl_startup_state_LOCK);`
`183`	`184`	`return memcached_set_error(*server, MEMCACHED_AUTH_PROBLEM, MEMCACHED_AT,`
`184`	`185`	`memcached_string_make_from_cstr(sasl_error_msg));`
`185`	`186`	`}`