Skip to content

Commit 1a5d567

Browse files
author
Olaf Hartig
committed
removed static code for registering the existing data source types
1 parent 5022839 commit 1a5d567

File tree

4 files changed

+14
-25
lines changed

4 files changed

+14
-25
lines changed

src/org/linkeddatafragments/datasource/hdt/HdtDataSourceType.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import java.io.File;
44
import java.io.IOException;
55

6-
import org.linkeddatafragments.datasource.DataSourceTypesRegistry;
76
import org.linkeddatafragments.datasource.IDataSource;
87
import org.linkeddatafragments.datasource.IDataSourceType;
98
import org.linkeddatafragments.exceptions.DataSourceException;
@@ -17,15 +16,6 @@
1716
*/
1817
public class HdtDataSourceType implements IDataSourceType
1918
{
20-
public static final String TYPE_NAME = "HdtDatasource";
21-
22-
public static void register() {
23-
if ( ! DataSourceTypesRegistry.isRegistered(TYPE_NAME) ) {
24-
DataSourceTypesRegistry.register( TYPE_NAME,
25-
new HdtDataSourceType() );
26-
}
27-
}
28-
2919
@Override
3020
public IDataSource createDataSource( final String title,
3121
final String description,

src/org/linkeddatafragments/datasource/tdb/JenaTDBDataSourceType.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import java.io.File;
44

5-
import org.linkeddatafragments.datasource.DataSourceTypesRegistry;
65
import org.linkeddatafragments.datasource.IDataSource;
76
import org.linkeddatafragments.datasource.IDataSourceType;
87
import org.linkeddatafragments.exceptions.DataSourceException;
@@ -17,15 +16,6 @@
1716
*/
1817
public class JenaTDBDataSourceType implements IDataSourceType
1918
{
20-
public static final String TYPE_NAME = "JenaTDBDatasource";
21-
22-
public static void register() {
23-
if ( ! DataSourceTypesRegistry.isRegistered(TYPE_NAME) ) {
24-
DataSourceTypesRegistry.register( TYPE_NAME,
25-
new JenaTDBDataSourceType() );
26-
}
27-
}
28-
2919
@Override
3020
public IDataSource createDataSource( final String title,
3121
final String description,

src/test/java/org/linkeddatafragments/datasource/HdtDataSourceTest.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import org.junit.Before;
88
import org.junit.BeforeClass;
99
import org.linkeddatafragments.datasource.DataSourceFactory;
10+
import org.linkeddatafragments.datasource.DataSourceTypesRegistry;
1011
import org.linkeddatafragments.datasource.hdt.HdtDataSourceType;
1112
import org.rdfhdt.hdt.enums.RDFNotation;
1213
import org.rdfhdt.hdt.hdt.HDT;
@@ -24,7 +25,11 @@ public class HdtDataSourceTest extends DataSourceTest {
2425

2526
@BeforeClass
2627
public static void setUpClass() throws Exception {
27-
HdtDataSourceType.register();
28+
final String typeName = "HdtTestSourceType";
29+
if ( ! DataSourceTypesRegistry.isRegistered(typeName) ) {
30+
DataSourceTypesRegistry.register( typeName, new HdtDataSourceType() );
31+
}
32+
2833
// HDT does not seem to support an InputReader, so write to temp file
2934
File temp = getResourceAsFile();
3035

@@ -37,8 +42,7 @@ public static void setUpClass() throws Exception {
3742
temp.getAbsoluteFile().delete();
3843

3944
// Everything is in place, now create the LDF datasource
40-
JsonObject config = createConfig("hdt test", "hdt test",
41-
HdtDataSourceType.TYPE_NAME);
45+
JsonObject config = createConfig("hdt test", "hdt test", typeName);
4246

4347
JsonObject settings = new JsonObject();
4448
settings.addProperty("file", hdtfile.getAbsolutePath());

src/test/java/org/linkeddatafragments/datasource/JenaTDBDataSourceTest.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import org.junit.BeforeClass;
2020

2121
import org.linkeddatafragments.datasource.DataSourceFactory;
22+
import org.linkeddatafragments.datasource.DataSourceTypesRegistry;
2223
import org.linkeddatafragments.datasource.tdb.JenaTDBDataSourceType;
2324

2425
/**
@@ -31,7 +32,11 @@ public class JenaTDBDataSourceTest extends DataSourceTest {
3132

3233
@BeforeClass
3334
public static void setUpClass() throws Exception {
34-
JenaTDBDataSourceType.register();
35+
final String typeName = "JenaSourceType";
36+
if ( ! DataSourceTypesRegistry.isRegistered(typeName) ) {
37+
DataSourceTypesRegistry.register( typeName,
38+
new JenaTDBDataSourceType() );
39+
}
3540

3641
String tmpdir = System.getProperty("java.io.tmpdir");
3742
jena = new File(tmpdir, "ldf-jena-test");
@@ -46,7 +51,7 @@ public static void setUpClass() throws Exception {
4651

4752
// Everything is in place, now create the LDF datasource
4853
JsonObject config = createConfig("jena tdb test", "jena tdb test",
49-
JenaTDBDataSourceType.TYPE_NAME);
54+
typeName);
5055

5156
JsonObject settings = new JsonObject();
5257
settings.addProperty("directory", jena.getAbsolutePath());

0 commit comments

Comments
 (0)