Skip to content

Commit 3e9a743

Browse files
fix: update ncc and minor workflow enhancements (#269)
* updated deprecated ncc version and added nodejs 18 to github workflows * corrected package ncc and added lock file --------- Co-authored-by: Sapeksh Madan <[email protected]>
1 parent 1e00aa6 commit 3e9a743

File tree

4 files changed

+27
-17
lines changed

4 files changed

+27
-17
lines changed

.github/workflows/check.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,23 @@ name: Check
66
jobs:
77
check:
88
name: Run Unit Tests
9-
runs-on: ubuntu-latest
9+
runs-on: ubuntu-22.04
1010
steps:
1111
- name: Checkout
12-
uses: actions/checkout@v2
12+
#Version actions/[email protected]
13+
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
14+
- name: Node setup
15+
#Version actions/[email protected]
16+
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d
17+
with:
18+
node-version: "18.16.1"
1319
- name: Run tests
1420
run: |
1521
npm ci
1622
npm test
17-
1823
conventional-commits:
1924
name: Semantic Pull Request
20-
runs-on: ubuntu-latest
25+
runs-on: ubuntu-22.04
2126
steps:
2227
- name: validate
2328
uses: actions/github-script@v6

.github/workflows/package.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,18 @@ name: Package
88
jobs:
99
check:
1010
name: Package distribution file
11-
runs-on: ubuntu-latest
11+
runs-on: ubuntu-22.04
1212
steps:
1313
- name: Checkout
14-
uses: actions/checkout@v2
14+
#Version actions/[email protected]
15+
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
1516
with:
1617
ref: master
18+
- name: Node setup
19+
#Version actions/[email protected]
20+
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d
21+
with:
22+
node-version: "18.16.1"
1723
- name: Package
1824
run: |
1925
npm ci

package-lock.json

Lines changed: 9 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"tmp": "^0.2.1"
3030
},
3131
"devDependencies": {
32-
"@zeit/ncc": "^0.22.3",
32+
"@vercel/ncc": "^0.38.0",
3333
"eslint": "^8.50.0",
3434
"jest": "^29.7.0"
3535
}

0 commit comments

Comments
 (0)