Skip to content

Commit 63285fe

Browse files
committed
Update VolumeConfigurations to be a empty list instead of not passing it during subsequent Update Service Calls
1 parent f0981f6 commit 63285fe

File tree

2 files changed

+8
-14
lines changed

2 files changed

+8
-14
lines changed

dist/index.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ async function runTask(ecs, clusterName, taskDefArn, waitForMinutes, enableECSMa
5555
if(assignPublicIP != "" && (subnetIds != "" || securityGroupIds != "")){
5656
awsvpcConfiguration["assignPublicIp"] = assignPublicIP
5757
}
58-
let volumeConfigurations = null;
58+
let volumeConfigurations = [];
5959
let taskManagedEBSVolumeObject;
6060

6161
if (runTaskManagedEBSVolumeName != '') {
@@ -203,7 +203,7 @@ async function updateEcsService(ecs, clusterName, service, taskDefArn, waitForSe
203203
const serviceManagedEBSVolumeName = core.getInput('service-managed-ebs-volume-name', { required: false }) || '';
204204
const serviceManagedEBSVolume = core.getInput('service-managed-ebs-volume', { required: false }) || '{}';
205205

206-
let volumeConfigurations = null;
206+
let volumeConfigurations = [];
207207
let serviceManagedEbsVolumeObject;
208208

209209
if (serviceManagedEBSVolumeName != '') {
@@ -224,17 +224,14 @@ async function updateEcsService(ecs, clusterName, service, taskDefArn, waitForSe
224224
taskDefinition: taskDefArn,
225225
forceNewDeployment: forceNewDeployment,
226226
enableECSManagedTags: enableECSManagedTags,
227-
propagateTags: propagateTags
227+
propagateTags: propagateTags,
228+
volumeConfigurations: volumeConfigurations
228229
};
229230

230231
// Add the desiredCount property only if it is defined and a number.
231232
if (!isNaN(desiredCount) && desiredCount !== undefined) {
232233
params.desiredCount = desiredCount;
233234
}
234-
// Add VolumeConfigurations property only it is not null
235-
if(volumeConfigurations !== null){
236-
params.volumeConfigurations = volumeConfigurations;
237-
}
238235
await ecs.updateService(params);
239236

240237
const region = await ecs.config.region();

index.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ async function runTask(ecs, clusterName, taskDefArn, waitForMinutes, enableECSMa
4949
if(assignPublicIP != "" && (subnetIds != "" || securityGroupIds != "")){
5050
awsvpcConfiguration["assignPublicIp"] = assignPublicIP
5151
}
52-
let volumeConfigurations = null;
52+
let volumeConfigurations = [];
5353
let taskManagedEBSVolumeObject;
5454

5555
if (runTaskManagedEBSVolumeName != '') {
@@ -197,7 +197,7 @@ async function updateEcsService(ecs, clusterName, service, taskDefArn, waitForSe
197197
const serviceManagedEBSVolumeName = core.getInput('service-managed-ebs-volume-name', { required: false }) || '';
198198
const serviceManagedEBSVolume = core.getInput('service-managed-ebs-volume', { required: false }) || '{}';
199199

200-
let volumeConfigurations = null;
200+
let volumeConfigurations = [];
201201
let serviceManagedEbsVolumeObject;
202202

203203
if (serviceManagedEBSVolumeName != '') {
@@ -218,17 +218,14 @@ async function updateEcsService(ecs, clusterName, service, taskDefArn, waitForSe
218218
taskDefinition: taskDefArn,
219219
forceNewDeployment: forceNewDeployment,
220220
enableECSManagedTags: enableECSManagedTags,
221-
propagateTags: propagateTags
221+
propagateTags: propagateTags,
222+
volumeConfigurations: volumeConfigurations
222223
};
223224

224225
// Add the desiredCount property only if it is defined and a number.
225226
if (!isNaN(desiredCount) && desiredCount !== undefined) {
226227
params.desiredCount = desiredCount;
227228
}
228-
// Add VolumeConfigurations property only it is not null
229-
if(volumeConfigurations !== null){
230-
params.volumeConfigurations = volumeConfigurations;
231-
}
232229
await ecs.updateService(params);
233230

234231
const region = await ecs.config.region();

0 commit comments

Comments
 (0)