Skip to content

Commit c279797

Browse files
committed
final changes from comments
1 parent 3978fee commit c279797

File tree

3 files changed

+0
-15
lines changed

3 files changed

+0
-15
lines changed

dist/index.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ const { ECS, waitUntilServicesStable, waitUntilTasksStopped } = __nccwpck_requir
1111
const yaml = __nccwpck_require__(4083);
1212
const fs = __nccwpck_require__(7147);
1313
const crypto = __nccwpck_require__(6113);
14-
//const { default: cluster } = require('cluster');
15-
1614
const MAX_WAIT_MINUTES = 360; // 6 hours
1715
const WAIT_DEFAULT_DELAY_SEC = 15;
1816

@@ -345,11 +343,6 @@ async function createCodeDeployDeployment(codedeploy, clusterName, service, task
345343
}
346344
};
347345
// If it hasn't been set then we don't even want to pass it to the api call to maintain previous behaviour.
348-
let codeDeployDescriptionLimit = 512;
349-
350-
if (codeDeployDescription) {
351-
deploymentParams.description = (codeDeployDescription.length <= codeDeployDescriptionLimit) ? codeDeployDescription : `${codeDeployDescription.substring(0,511)}…`;
352-
}
353346
if (codeDeployConfig) {
354347
deploymentParams.deploymentConfigName = codeDeployConfig
355348
}

index.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ const { ECS, waitUntilServicesStable, waitUntilTasksStopped } = require('@aws-sd
55
const yaml = require('yaml');
66
const fs = require('fs');
77
const crypto = require('crypto');
8-
//const { default: cluster } = require('cluster');
9-
108
const MAX_WAIT_MINUTES = 360; // 6 hours
119
const WAIT_DEFAULT_DELAY_SEC = 15;
1210

@@ -339,11 +337,6 @@ async function createCodeDeployDeployment(codedeploy, clusterName, service, task
339337
}
340338
};
341339
// If it hasn't been set then we don't even want to pass it to the api call to maintain previous behaviour.
342-
let codeDeployDescriptionLimit = 512;
343-
344-
if (codeDeployDescription) {
345-
deploymentParams.description = (codeDeployDescription.length <= codeDeployDescriptionLimit) ? codeDeployDescription : `${codeDeployDescription.substring(0,511)}…`;
346-
}
347340
if (codeDeployConfig) {
348341
deploymentParams.deploymentConfigName = codeDeployConfig
349342
}

index.test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -872,7 +872,6 @@ describe('Deploy to ECS', () => {
872872
applicationName: 'Custom-Application',
873873
deploymentGroupName: 'Custom-Deployment-Group',
874874
deploymentConfigName: 'CodeDeployDefault.AllAtOnce',
875-
description: 'Custom-Deployment',
876875
revision: {
877876
revisionType: 'AppSpecContent',
878877
appSpecContent: {

0 commit comments

Comments
 (0)