Skip to content

Commit cc490ca

Browse files
amazreechamazreech
committed
Update convertToManagedEbsVolumeObject syntax
1 parent 41cb704 commit cc490ca

File tree

2 files changed

+28
-24
lines changed

2 files changed

+28
-24
lines changed

‎dist/index.js

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -114,39 +114,40 @@ async function convertToManagedEbsVolumeObject(managedEbsVolume) {
114114
managedEbsVolumeObject = {}
115115
const ebsVolumeObject = JSON.parse(managedEbsVolume);
116116
if ('roleArn' in ebsVolumeObject){ // required property
117-
managedEbsVolumeObject['roleArn'] = ebsVolumeObject['roleArn'];
117+
managedEbsVolumeObject.roleArn = ebsVolumeObject.roleArn;
118118
core.debug(`Found RoleArn ${ebsVolumeObject['roleArn']}`);
119119
} else {
120120
throw new Error('managed-ebs-volume must provide "role-arn" to associate with the EBS volume')
121121
}
122122

123123
if ('encrypted' in ebsVolumeObject) {
124-
managedEbsVolumeObject['encrypted'] = ebsVolumeObject.encrypted;
124+
managedEbsVolumeObject.encrypted = ebsVolumeObject.encrypted;
125125
}
126126
if ('filesystemType' in ebsVolumeObject) {
127-
managedEbsVolumeObject['filesystemType'] = ebsVolumeObject.filesystemType;
127+
managedEbsVolumeObject.filesystemType = ebsVolumeObject.filesystemType;
128128
}
129129
if ('iops' in ebsVolumeObject) {
130-
managedEbsVolumeObject['iops'] = ebsVolumeObject.iops;
130+
managedEbsVolumeObject.iops = ebsVolumeObject.iops;
131131
}
132132
if ('kmsKeyId' in ebsVolumeObject) {
133-
managedEbsVolumeObject['kmsKeyId'] = ebsVolumeObject.kmsKeyId;
133+
managedEbsVolumeObject.kmsKeyId = ebsVolumeObject.kmsKeyId;
134134
}
135135
if ('sizeInGiB' in ebsVolumeObject) {
136-
managedEbsVolumeObject['sizeInGiB'] = ebsVolumeObject.sizeInGiB;
136+
managedEbsVolumeObject.sizeInGiB = ebsVolumeObject.sizeInGiB;
137137
}
138138
if ('snapshotId' in ebsVolumeObject) {
139-
managedEbsVolumeObject['snapshotId'] = ebsVolumeObject.snapshotId;
139+
managedEbsVolumeObject.snapshotId = ebsVolumeObject.snapshotId;
140140
}
141141
if ('tagSpecifications' in ebsVolumeObject) {
142-
managedEbsVolumeObject['tagSpecifications'] = ebsVolumeObject.tagSpecifications;
142+
managedEbsVolumeObject.tagSpecifications = ebsVolumeObject.tagSpecifications;
143143
}
144144
if (('throughput' in ebsVolumeObject) && (('volumeType' in ebsVolumeObject) && (ebsVolumeObject.volumeType == 'gp3'))){
145-
managedEbsVolumeObject["throughput"] = ebsVolumeObject.throughput;
145+
managedEbsVolumeObject.throughput = ebsVolumeObject.throughput;
146146
}
147147
if ('volumeType' in ebsVolumeObject) {
148-
managedEbsVolumeObject['volumeType'] = ebsVolumeObject.volumeType;
148+
managedEbsVolumeObject.volumeType = ebsVolumeObject.volumeType;
149149
}
150+
core.debug(`Created managedEbsVolumeObject: ${JSON.stringify(managedEbsVolumeObject)}`);
150151
return managedEbsVolumeObject;
151152
}
152153

@@ -201,16 +202,17 @@ async function updateEcsService(ecs, clusterName, service, taskDefArn, waitForSe
201202
core.debug('Updating the provided ECS service');
202203

203204
const serviceManagedEbsVolumeName = core.getInput('service-managed-ebs-volume-name', { required: false }) || '';
204-
core.debug('serviceManagedEbsVolume Name: ${serviceManagedEbsVolumeName}');
205+
core.debug(`serviceManagedEbsVolume Name: ${serviceManagedEbsVolumeName}`);
205206
core.debug('serviceManagedEbsVolume Name.');
206207
const serviceManagedEbsVolume = core.getInput('service-managed-ebs-volume', { required: false }) || '{}';
207-
core.debug('serviceManagedEbsVolume Value: ${serviceManagedEbsVolume}');
208+
core.debug(`serviceManagedEbsVolume Value: ${serviceManagedEbsVolume}`);
208209
core.debug('serviceManagedEbsVolume Value.');
209210

210211
core.debug('Updating the service contd..');
211212

212213
let volumeConfigurations = []
213214
let volumeConfigurationJSON = {}
215+
let serviceManagedEbsVolumeObject;
214216

215217
if (serviceManagedEbsVolumeName != '') {
216218
core.debug(`Assigning VolumeConfiguration Name: ${serviceManagedEbsVolumeName}`);

‎index.js

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -108,39 +108,40 @@ async function convertToManagedEbsVolumeObject(managedEbsVolume) {
108108
managedEbsVolumeObject = {}
109109
const ebsVolumeObject = JSON.parse(managedEbsVolume);
110110
if ('roleArn' in ebsVolumeObject){ // required property
111-
managedEbsVolumeObject['roleArn'] = ebsVolumeObject['roleArn'];
111+
managedEbsVolumeObject.roleArn = ebsVolumeObject.roleArn;
112112
core.debug(`Found RoleArn ${ebsVolumeObject['roleArn']}`);
113113
} else {
114114
throw new Error('managed-ebs-volume must provide "role-arn" to associate with the EBS volume')
115115
}
116116

117117
if ('encrypted' in ebsVolumeObject) {
118-
managedEbsVolumeObject['encrypted'] = ebsVolumeObject.encrypted;
118+
managedEbsVolumeObject.encrypted = ebsVolumeObject.encrypted;
119119
}
120120
if ('filesystemType' in ebsVolumeObject) {
121-
managedEbsVolumeObject['filesystemType'] = ebsVolumeObject.filesystemType;
121+
managedEbsVolumeObject.filesystemType = ebsVolumeObject.filesystemType;
122122
}
123123
if ('iops' in ebsVolumeObject) {
124-
managedEbsVolumeObject['iops'] = ebsVolumeObject.iops;
124+
managedEbsVolumeObject.iops = ebsVolumeObject.iops;
125125
}
126126
if ('kmsKeyId' in ebsVolumeObject) {
127-
managedEbsVolumeObject['kmsKeyId'] = ebsVolumeObject.kmsKeyId;
127+
managedEbsVolumeObject.kmsKeyId = ebsVolumeObject.kmsKeyId;
128128
}
129129
if ('sizeInGiB' in ebsVolumeObject) {
130-
managedEbsVolumeObject['sizeInGiB'] = ebsVolumeObject.sizeInGiB;
130+
managedEbsVolumeObject.sizeInGiB = ebsVolumeObject.sizeInGiB;
131131
}
132132
if ('snapshotId' in ebsVolumeObject) {
133-
managedEbsVolumeObject['snapshotId'] = ebsVolumeObject.snapshotId;
133+
managedEbsVolumeObject.snapshotId = ebsVolumeObject.snapshotId;
134134
}
135135
if ('tagSpecifications' in ebsVolumeObject) {
136-
managedEbsVolumeObject['tagSpecifications'] = ebsVolumeObject.tagSpecifications;
136+
managedEbsVolumeObject.tagSpecifications = ebsVolumeObject.tagSpecifications;
137137
}
138138
if (('throughput' in ebsVolumeObject) && (('volumeType' in ebsVolumeObject) && (ebsVolumeObject.volumeType == 'gp3'))){
139-
managedEbsVolumeObject["throughput"] = ebsVolumeObject.throughput;
139+
managedEbsVolumeObject.throughput = ebsVolumeObject.throughput;
140140
}
141141
if ('volumeType' in ebsVolumeObject) {
142-
managedEbsVolumeObject['volumeType'] = ebsVolumeObject.volumeType;
142+
managedEbsVolumeObject.volumeType = ebsVolumeObject.volumeType;
143143
}
144+
core.debug(`Created managedEbsVolumeObject: ${JSON.stringify(managedEbsVolumeObject)}`);
144145
return managedEbsVolumeObject;
145146
}
146147

@@ -195,16 +196,17 @@ async function updateEcsService(ecs, clusterName, service, taskDefArn, waitForSe
195196
core.debug('Updating the provided ECS service');
196197

197198
const serviceManagedEbsVolumeName = core.getInput('service-managed-ebs-volume-name', { required: false }) || '';
198-
core.debug('serviceManagedEbsVolume Name: ${serviceManagedEbsVolumeName}');
199+
core.debug(`serviceManagedEbsVolume Name: ${serviceManagedEbsVolumeName}`);
199200
core.debug('serviceManagedEbsVolume Name.');
200201
const serviceManagedEbsVolume = core.getInput('service-managed-ebs-volume', { required: false }) || '{}';
201-
core.debug('serviceManagedEbsVolume Value: ${serviceManagedEbsVolume}');
202+
core.debug(`serviceManagedEbsVolume Value: ${serviceManagedEbsVolume}`);
202203
core.debug('serviceManagedEbsVolume Value.');
203204

204205
core.debug('Updating the service contd..');
205206

206207
let volumeConfigurations = []
207208
let volumeConfigurationJSON = {}
209+
let serviceManagedEbsVolumeObject;
208210

209211
if (serviceManagedEbsVolumeName != '') {
210212
core.debug(`Assigning VolumeConfiguration Name: ${serviceManagedEbsVolumeName}`);

0 commit comments

Comments
 (0)