-
Notifications
You must be signed in to change notification settings - Fork 260
Open
Labels
feature-requestA feature should be added or improved.A feature should be added or improved.
Description
Feature Description
Add a parameter to allow for keys that are empty to not be discarded when the new taskdef is created.
This parameter would be called keep-null-value-keys
and would accept a list of key names to not filter out if they are empty.
For example you could pass in:
keep-null-value-keys: tag
to retain any keys with the name tag
Problem Statement
We wanted to set our logging configuration in the taskdef to be this:
"logConfiguration": {
"logDriver": "splunk",
"options": {
"splunk-url": "http://splunk.dev.aws.resonatedigital.net:8088/",
"splunk-verify-connection": "false",
"splunk-sourcetype": "docker:json",
"splunk-index": "services-general-purpose",
"tag": "",
"splunk-format": "raw"
}
but when the taskdef was created by the action the key tag
was dropped from the newly created taskdef, this would result in tag
being assigned the default value which is not what we wanted.
Alternatives Considered/ Work-arounds
- disabling all discarding of null or empty values
- Tried alternate solutions done on the splunk side that are sub-optimal
Additional Context
N/A
Willingness to Contribute
Are you willing to submit a Pull Request for this feature? Yes
driskillb43, gitrc, gzub-resonate and gzub
Metadata
Metadata
Assignees
Labels
feature-requestA feature should be added or improved.A feature should be added or improved.