Skip to content

Commit 228a991

Browse files
authored
Update README.md for OIDC changes (#764)
1 parent 3c981da commit 228a991

File tree

1 file changed

+24
-4
lines changed

1 file changed

+24
-4
lines changed

README.md

Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,24 @@ calls.
77

88
### Recent updates
99

10-
**If you use OIDC, you may need to update your identity provider**
11-
10+
**GitHub OIDC Changes**
11+
12+
In #[357](https://github.com/aws-actions/configure-aws-credentials/issues/357), we
13+
observed that GitHub recently started offering one of several intermediate OIDC
14+
endpoint thumbprints. Because IAM requires statically configured endpoint
15+
thumbprints, AWS customers that had only one thumbprint configured could see
16+
intermittent authentication failures. **As of July 6, 2023, AWS has made a change to
17+
IAM that will no longer require any particular certificate thumbprint for
18+
tokens.actions.githubusercontent.com**, which is the GitHub OIDC endpoint. Instead,
19+
AWS secures communication with GitHub OIDC using our library of trusted CAs rather
20+
than using a certificate thumbprint to verify the server certificate. The IAM APIs
21+
still require that a thumbprint is configured, but those thumbprints will be ignored
22+
when authenticating tokens.actions.githubusercontent.com.
23+
24+
GitHub Enterprise Server customers use a different endpoint so they are not affected by
25+
this change.
26+
27+
*Original message:*
1228
There are now [two possible intermediary certificates](https://github.blog/changelog/2023-06-27-github-actions-update-on-oidc-integration-with-aws/) for the Actions SSL certificate. Previously, the certificate with the thumbprint `6938fd4d98bab03faadb97b34396831e3780aea1` was guaranteed to return. Now, the certificate with the thumbprint `1c58a3a8518e8759bf075b76b750d4f2df264fcd` can also be returned, so you will need to [update your identity provider](https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_providers_create_oidc.html) with this additional new thumbprint.
1329

1430
### Table of Contents
@@ -201,6 +217,11 @@ with the provider in as an IAM IdP. The GitHub OIDC provider only needs to be
201217
created once per account (i.e. multiple IAM Roles that can be assumed by the
202218
GitHub's OIDC can share a single OIDC Provider).
203219

220+
Note that the thumbprint has been set to all F's because the thumbprint is not
221+
used when authenticating tokens.actions.githubusercontent.com. Instead, IAM
222+
uses its library of trusted CAs to authenticate. However, this value is still
223+
required by the API.
224+
204225
This CloudFormation template will configure the IdP for you.
205226
```yaml
206227
Parameters:
@@ -251,8 +272,7 @@ Resources:
251272
ClientIdList:
252273
- sts.amazonaws.com
253274
ThumbprintList:
254-
- 6938fd4d98bab03faadb97b34396831e3780aea1
255-
- 1c58a3a8518e8759bf075b76b750d4f2df264fcd
275+
- ffffffffffffffffffffffffffffffffffffffff
256276
257277
Outputs:
258278
Role:

0 commit comments

Comments
 (0)