Skip to content

Commit 1252db2

Browse files
authored
fix: check_api_changes often fails on network error (#3010)
<!-- Thank you for your Pull Request! Please describe the problem this PR fixes and a summary of the changes made. Link to any relevant issues, code snippets, or other PRs. For trivial changes, this template can be ignored in favor of a short description of the changes. --> ## Problem <!-- Describe the issue this PR is solving --> <img width="1075" height="542" alt="Screenshot 2025-09-30 at 15 01 05" src="https://github.com/user-attachments/assets/5625a64a-c63f-48ed-a0cc-ecb4a61c95c0" /> ## Changes <!-- Summarize the changes introduced in this PR. This is a good place to call out critical or potentially problematic parts of the change. --> Added a 3x retry to `check_api_changes` on a commonly failing step. ## Validation <!-- Describe how changes in this PR have been validated. This may include added or updated unit, integration and/or E2E tests, test workflow runs, or manual verification. If manual verification is the only way changes in this PR have been validated, you will need to write some automated tests before this PR is ready to merge. For changes to test infra, or non-functional changes, tests are not always required. Instead, you should call out _why_ you think tests are not required here. If changes affect a GitHub workflow that is not included in the PR checks, include a link to a passing test run of the modified workflow. ---> Running the workflow in this PR. ## Checklist <!-- These items must be completed before a PR is ready to be merged. Feel free to publish a draft PR before these items are complete. --> - [X] If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change. - [X] If this PR requires a change to the [Project Architecture README](../PROJECT_ARCHITECTURE.md), I have included that update in this PR. - [X] If this PR requires a docs update, I have linked to that docs PR above. - [X] If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the `run-e2e` label set. _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license._
1 parent d4e7863 commit 1252db2

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

.github/workflows/health_checks.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -267,10 +267,15 @@ jobs:
267267
with:
268268
path: base-branch-content
269269
ref: ${{ github.event.pull_request.base.sha }}
270-
- name: Check API changes
271-
run: |
272-
mkdir api-validation-projects
273-
npx tsx scripts/check_api_changes.ts base-branch-content api-validation-projects
270+
- name: Check API changes with retry
271+
uses: nick-fields/retry@v3
272+
with:
273+
timeout_minutes: 20
274+
max_attempts: 3
275+
retry_wait_seconds: 30
276+
command: |
277+
mkdir -p api-validation-projects
278+
npx tsx scripts/check_api_changes.ts base-branch-content api-validation-projects
274279
handle_dependabot_version_update:
275280
if: github.event_name == 'pull_request' && github.event.pull_request.user.login == 'dependabot[bot]'
276281
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)