remove static (#1040)

* remove static

* add changeset

* update API.md

* refactor BackendIdentifierConversions and ParameterPathConversions

* update API.md

* revert remove static changes

* add rule to remove static

* modify the error messsage

* add lint rules to ban static method with exception

* fix lint for DeployedBackendClientFactory

* update API.md

* update changeset

* fix eslintrc lint

* Update .changeset/tidy-readers-prove.md

Co-authored-by: Kamil Sobol <[email protected]>

* use comment to disable static rule

* ignore getInstance

* Revert "ignore getInstance"

This reverts commit bcd9036.

---------

Co-authored-by: Kamil Sobol <[email protected]>

Author: 0618

.changeset/tidy-readers-prove.md

@@ -0,0 +1,5 @@
+---
+'@aws-amplify/deployed-backend-client': minor
+---
+
+remove static method

.eslintrc.cjs

@@ -141,6 +141,10 @@ module.exports = {
       'MethodDefinition[kind!=/[constructor|get]/]',
       'FunctionDeclaration',
       'VariableDeclarator > FunctionExpression',
+      {
+        selector: 'MethodDefinition[static=true]',
+        message: 'Static methods are not allowed in classes.',
+      },
     ],
     'jsdoc/require-description': 'error',
     'jsdoc/require-jsdoc': [

packages/deployed-backend-client/API.md

@@ -133,7 +133,7 @@ export type DeployedBackendClient = {
 
 // @public
 export class DeployedBackendClientFactory {
-    static getInstance(options: DeployedBackendClientFactoryOptions): DeployedBackendClient;
+    getInstance(options: DeployedBackendClientFactoryOptions): DeployedBackendClient;
 }
 
 // @public (undocumented)

packages/deployed-backend-client/src/deployed_backend_client_factory.ts

@@ -128,7 +128,7 @@ export class DeployedBackendClientFactory {
   /**
    * Returns a single instance of DeploymentClient
    */
-  static getInstance(
+  getInstance(
     options: DeployedBackendClientFactoryOptions
   ): DeployedBackendClient {
     const stackStatusMapper = new StackStatusMapper();

packages/platform-core/src/backend_identifier_conversions.ts

@@ -15,6 +15,8 @@ export class BackendIdentifierConversions {
    *
    * If the stack name is ambiguous, undefined is returned
    */
+  // It's fine to ignore the rule here because the anti-static rule is to ban the static function which should use constructor
+  // eslint-disable-next-line no-restricted-syntax
   static fromStackName(stackName?: string): BackendIdentifier | undefined {
     if (!stackName) {
       return;
@@ -47,6 +49,8 @@ export class BackendIdentifierConversions {
    *
    * Changing this method will change how stack names are generated which could be a massive breaking change for existing Amplify stacks.
    */
+  // It's fine to ignore the rule here because the anti-static rule is to ban the static function which should use constructor
+  // eslint-disable-next-line no-restricted-syntax
   static toStackName(backendId: BackendIdentifier): string {
     const hash = getHash(backendId);
 

packages/platform-core/src/parameter_path_conversions.ts

@@ -11,6 +11,8 @@ export class ParameterPathConversions {
   /**
    * Convert a BackendIdentifier to a parameter prefix.
    */
+  // It's fine to ignore the rule here because the anti-static rule is to ban the static function which should use constructor
+  // eslint-disable-next-line no-restricted-syntax
   static toParameterPrefix(backendId: BackendIdentifier | AppId): string {
     if (typeof backendId === 'object') {
       return getBackendParameterPrefix(backendId);
@@ -21,6 +23,8 @@ export class ParameterPathConversions {
   /**
    * Convert a BackendIdentifier to a parameter full path.
    */
+  // It's fine to ignore the rule here because the anti-static rule is to ban the static function which should use constructor
+  // eslint-disable-next-line no-restricted-syntax
   static toParameterFullPath(
     backendId: BackendIdentifier | AppId,
     parameterName: string
@@ -34,6 +38,8 @@ export class ParameterPathConversions {
   /**
    * Generate an SSM path for references to other backend resources
    */
+  // It's fine to ignore the rule here because the anti-static rule is to ban the static function which should use constructor
+  // eslint-disable-next-line no-restricted-syntax
   static toResourceReferenceFullPath(
     backendId: BackendIdentifier,
     referenceName: string