Skip to content

Commit 4374048

Browse files
author
Kamil Sobol
authored
Move pinning of CDK version to customer's project (#889)
* Move pinning of CDK version to customer's project * and that * fix test * fix test
1 parent 8f4baf4 commit 4374048

File tree

5 files changed

+20
-3
lines changed

5 files changed

+20
-3
lines changed

.changeset/clever-eels-confess.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'create-amplify': patch
3+
'@aws-amplify/backend': minor
4+
---
5+
6+
Move pinning of CDK version from @aws-amplify/backend to customer's project

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/backend/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"@aws-sdk/client-amplify": "^3.440.0"
3535
},
3636
"peerDependencies": {
37-
"aws-cdk-lib": "~2.110.1",
37+
"aws-cdk-lib": "^2.110.1",
3838
"constructs": "^10.0.0"
3939
},
4040
"devDependencies": {

packages/create-amplify/src/amplify_project_creator.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ export class AmplifyProjectCreator {
1414
private readonly defaultDevPackages = [
1515
'@aws-amplify/backend',
1616
'@aws-amplify/backend-cli',
17+
// TODO figure out how do we manage CDK version here as part of https://github.com/aws-amplify/amplify-backend/issues/392
18+
19+
20+
'constructs@^10.0.0',
1721
'typescript@^5.0.0',
1822
];
1923

packages/integration-tests/src/test-e2e/create_amplify.test.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,14 @@ void describe(
8282

8383
assert.deepStrictEqual(
8484
Object.keys(packageJsonObject.devDependencies).sort(),
85-
['@aws-amplify/backend', '@aws-amplify/backend-cli', 'typescript']
85+
[
86+
'@aws-amplify/backend',
87+
'@aws-amplify/backend-cli',
88+
'aws-cdk',
89+
'aws-cdk-lib',
90+
'constructs',
91+
'typescript',
92+
]
8693
);
8794

8895
assert.deepStrictEqual(

0 commit comments

Comments
 (0)