Skip to content

Commit 521bbb0

Browse files
authored
catch errors during secret refreshes (#2438)
* catch errors during secret refreshes * switch to try catch and add console.debug * PR feedback
1 parent 0a85696 commit 521bbb0

File tree

3 files changed

+26
-3
lines changed

3 files changed

+26
-3
lines changed

.changeset/good-tigers-cover.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@aws-amplify/backend-function': patch
3+
---
4+
5+
catch errors during secret refreshes
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"rules": {
3+
"no-console": "off"
4+
}
5+
}

packages/backend-function/src/lambda-shims/invoke_ssm_shim.ts

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,19 @@ await internalAmplifyFunctionResolveSsmParams();
88

99
const SSM_PARAMETER_REFRESH_MS = 1000 * 60;
1010

11-
setInterval(() => {
12-
void internalAmplifyFunctionResolveSsmParams();
13-
}, SSM_PARAMETER_REFRESH_MS);
11+
setInterval(
12+
void (async () => {
13+
try {
14+
await internalAmplifyFunctionResolveSsmParams();
15+
} catch (error) {
16+
try {
17+
// Attempt to log error
18+
console.debug(error);
19+
// eslint-disable-next-line amplify-backend-rules/no-empty-catch
20+
} catch (error) {
21+
// Do nothing if logging fails
22+
}
23+
}
24+
}),
25+
SSM_PARAMETER_REFRESH_MS
26+
);

0 commit comments

Comments
 (0)