PR feedback

Author: Vieltojarvi

packages/cli/src/commands/sandbox/sandbox-seed/sandbox_seed_command.ts

@@ -47,11 +47,9 @@ export class SandboxSeedCommand implements CommandModule<object> {
           AMPLIFY_BACKEND_IDENTIFIER: JSON.stringify(backendID),
         },
       });
-    } catch (err) {
+    } finally {
       printer.stopSpinner();
-      throw err;
     }
-    printer.stopSpinner();
     printer.printNewLine();
     printer.print(`${format.success('✔')} seed has successfully completed`);
   };

packages/integration-tests/src/test-project-setup/seed_test_project.ts

@@ -120,7 +120,7 @@ class SeedTestProject extends TestProjectBase {
     const command = execaSync('npx', ['which', 'ampx'], {
       cwd: this.projectDirPath,
     }).stdout.trim();
-    const seedPolicyProcess = await execa(
+    const seedPolicyProcessResult = await execa(
       command,
       ['sandbox', 'seed', 'generate-policy'],
       {
@@ -129,8 +129,9 @@ class SeedTestProject extends TestProjectBase {
       },
     );
 
-    const startingInd = seedPolicyProcess.stdout.indexOf('{');
-    const cleanedPolicyString = seedPolicyProcess.stdout.slice(startingInd);
+    const startingInd = seedPolicyProcessResult.stdout.indexOf('{');
+    const cleanedPolicyString =
+      seedPolicyProcessResult.stdout.slice(startingInd);
 
     const clientConfig = await generateClientConfig(backendIdentifier, '1.3');
     if (!clientConfig.custom) {
@@ -212,6 +213,7 @@ class SeedTestProject extends TestProjectBase {
             items {
               id
               content
+              owner
             }
           }
         }
@@ -222,5 +224,6 @@ class SeedTestProject extends TestProjectBase {
       content.data.listTodos.items[0].content,
       `Todo list item for ${testUsername}`,
     );
+    assert.ok(content.data.listTodos.items[0].owner);
   }
 }

packages/integration-tests/src/test-projects/seed-test-project/amplify/seed/seed.ts

@@ -2,11 +2,14 @@ import { createAndSignUpUser, signInUser } from '@aws-amplify/seed';
 import * as auth from 'aws-amplify/auth';
 import type { Schema } from './../data/resource.js';
 import { Amplify } from 'aws-amplify';
-// @ts-ignore typescript does not like this import
-import outputs from '../../amplify_outputs.json';
 import { generateClient } from 'aws-amplify/api';
 import { SemVer } from 'semver';
 import crypto from 'node:crypto';
+import { readFile } from 'node:fs/promises';
+
+const outputFile = JSON.parse(
+  await readFile('../../amplify_outputs.json', { encoding: 'utf8' }),
+);
 
 // TODO: this is a work around - in theory this should be fixed
 // it seems like as of amplify v6 , some of the code only runs in the browser ...
@@ -19,12 +22,12 @@ if (process.versions.node) {
   }
 }
 
-Amplify.configure(outputs);
+Amplify.configure(outputFile);
 
 const dataClient = generateClient<Schema>();
 
-const username1 = 'testUser@testing.com';
-const password1 = 'T3st_Passw0rd*';
+const username1 = 'testUser@amazon.com';
+const password1 = `T3st_Passw0rd*${Math.random()}`;
 
 const user1 = await createAndSignUpUser({
   username: username1,