Skip to content

Commit 8cbd5b9

Browse files
rix0rrrmrgrain
andauthored
chore: update package-lock.json (#2997)
* chore: update `package-lock.json` When running `npm ci`, we get the following error: ``` npm error `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing. npm error npm error Missing: @aws-cdk/[email protected] from lock file npm error Missing: @aws-cdk/[email protected] from lock file npm error Missing: @aws-cdk/[email protected] from lock file npm error Missing: [email protected] from lock file npm error Missing: [email protected] from lock file npm error Missing: [email protected] from lock file npm error Missing: [email protected] from lock file npm error Missing: @aws-cdk/[email protected] from lock file npm error Missing: @isaacs/[email protected] from lock file npm error Missing: @isaacs/[email protected] from lock file ``` This indicates that the lockfile is not really being used, which feels dangerous. We need to hunt down why the build succeeds everywhere even though the lockfile is not used (probably means we use `npm install` everywhere instead of `npm ci`), but this is at least a first step. * Also other places --------- Co-authored-by: Momo Kornher <[email protected]>
1 parent 83d5962 commit 8cbd5b9

File tree

5 files changed

+230
-738
lines changed

5 files changed

+230
-738
lines changed

.changeset/little-houses-think.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ npm run setup:local
5656
npm run test
5757
```
5858

59-
`npm run setup:local` will run `npm install`, then build all packages in the project. It also links the ampx and create-amplify bin files into the project node_modules folder.
59+
`npm run setup:local` will run `npm ci`, then build all packages in the project. It also links the ampx and create-amplify bin files into the project node_modules folder.
6060

6161
`npm run test` will run all the unit tests in the project
6262

0 commit comments

Comments
 (0)