Bundle form-gernerator and @graphql-codegen/core together to address Yarn 4.x (#2903)

* Ensure that @graphql-tools/merge pinning works for Yarn 4.x

* Ensure that @graphql-tools/merge pinning works for Yarn 4.x

* try this

* Try this

* try-this

* try this

* try this

* try this

* try this

* try this

* fix this

* fix that

* fix build

* pr feedback

* and this

Author: sobolk

.c8rc.json

@@ -8,6 +8,7 @@
     "templates",
     "**/*.test.ts",
     "packages/ai-constructs/lib/conversation/runtime/default_handler_bundled",
+    "packages/form-generator/lib/bundled",
     "packages/plugin-types",
     "packages/integration-tests"
   ],

.changeset/famous-results-film.md

@@ -0,0 +1,5 @@
+---
+'@aws-amplify/form-generator': patch
+---
+
+Ensure that @graphql-tools/merge pinning works for Yarn 4.x

.eslintignore

@@ -16,3 +16,6 @@ packages/client-config/src/client-config-schema
 
 # Directory below is git-ignored. We create and delete test projects in e2e tests there.
 packages/integration-tests/src/e2e-tests
+
+# This causes OOM
+packages/form-generator/bundle.js

package-lock.json

@@ -12,7 +12,7 @@
     "check:package-versions": "tsx scripts/check_package_versions.ts",
     "check:tsconfig-refs": "npm run update:tsconfig-refs && tsx scripts/check_no_git_diff.ts",
     "clean": "npm run clean:build && npm run clean:npm-proxy && rimraf --glob node_modules coverage .eslintcache packages/*/temp packages/*/node_modules",
-    "clean:build": "rimraf --glob packages/*/lib packages/*/tsconfig.tsbuildinfo",
+    "clean:build": "rimraf --glob packages/*/lib packages/*/tsconfig.tsbuildinfo scripts/concurrent_workspace_script_cache.json",
     "clean:npm-proxy": "npm run stop:npm-proxy && rimraf verdaccio-cache verdaccio-logs.txt",
     "diff:check": "tsx scripts/check_pr_size.ts",
     "docs": "typedoc",
@@ -69,6 +69,7 @@
     "@changesets/cli": "^2.26.1",
     "@changesets/get-release-plan": "^4.0.0",
     "@changesets/types": "^6.0.0",
+    "@graphql-codegen/core": "^4.0.0",
     "@microsoft/api-extractor": "7.43.8",
     "@octokit/webhooks-types": "^7.5.1",
     "@shopify/eslint-plugin": "^43.0.0",

package.json

@@ -0,0 +1,27 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+import esbuild from 'esbuild';
+import fs from 'fs';
+let pkg = JSON.parse(fs.readFileSync('package.json'));
+
+// Note: This is due to https://github.com/aws-amplify/amplify-backend/issues/2901
+// The goal is to bundle form-generator code and @graphql-codegen/core dependency only.
+// (minimal viable solution until we figure out global bundling strategy).
+// 1. @graphql-codegen/core dependency was moved to root package.json.
+//    This ensures that package managers don't attempt to install it.
+//    E.g. Yarn 4.x attempts to install any dependency, prod, dev, bundled not respecting NPM spec.
+// 2. All other dependencies (that are not problematic at this time) are listed in 'pkg.dependencies' and are exluded from bundling.
+//    An attempt to bundle them results in 35MB bundle size and runtime errors like 'Dynamic require of \"buffer\" is not supported'.
+//   These dependencies will be installed by package managers in custmer project.
+let external = Object.keys(pkg.dependencies);
+
+await esbuild.build({
+  entryPoints: ['src/index.ts'],
+  bundle: true,
+  outfile: 'lib/bundled/index.js',
+  external,
+  logLevel: 'info',
+  platform: 'node',
+  target: 'node18',
+  format: 'esm',
+  sourcemap: true,
+});

packages/form-generator/bundle.js

@@ -8,21 +8,18 @@
   "exports": {
     ".": {
       "types": "./lib/index.d.ts",
-      "import": "./lib/index.js",
-      "require": "./lib/index.js"
+      "import": "./lib/bundled/index.js",
+      "require": "./lib/bundled/index.js"
     }
   },
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
   "scripts": {
-    "post:compile": "npm run copy:dependencies",
-    "copy:dependencies": "mkdir -p node_modules && cp -R ../../node_modules/@graphql-codegen node_modules/",
+    "post:compile": "npm run bundle",
+    "bundle": "node bundle.js",
     "update:api": "api-extractor run --local"
   },
   "license": "Apache-2.0",
-  "bundledDependencies": [
-    "@graphql-codegen/core"
-  ],
   "dependencies": {
     "@aws-amplify/appsync-modelgen-plugin": "^2.11.0",
     "@aws-amplify/codegen-ui": "^2.19.4",
@@ -32,14 +29,9 @@
     "@aws-sdk/client-amplifyuibuilder": "^3.750.0",
     "@aws-sdk/client-appsync": "^3.750.0",
     "@aws-sdk/client-s3": "^3.750.0",
-    "@graphql-codegen/core": "^4.0.0",
     "@graphql-codegen/typescript": "^4.1.5",
-    "@graphql-tools/merge": "9.0.22",
     "graphql": "^15.8.0",
     "node-fetch": "^3.3.2",
     "prettier": "^3.5.3"
-  },
-  "overrides": {
-    "@graphql-tools/merge": "9.0.22"
   }
 }

packages/form-generator/package.json

@@ -4,6 +4,9 @@ import {
   getGenericFromDataStore,
 } from '@aws-amplify/codegen-ui';
 import { parse } from 'graphql';
+// @graphql-codegen/core is moved to root package.json and bundled
+// with esbuild due to https://github.com/aws-amplify/amplify-backend/issues/2901
+// eslint-disable-next-line import/no-extraneous-dependencies
 import * as graphqlCodegen from '@graphql-codegen/core';
 import * as appsync from '@aws-amplify/appsync-modelgen-plugin';
 import { DefaultDirectives, Directive } from '@aws-amplify/graphql-directives';