Windows e2e deployment timeout update (#779)

* bump sandbox deploy threshold on windows

* add changeset

* update comment

* update threshold

* refactor windows specific threshold

Author: edwardfoyle

.changeset/red-berries-promise.md

@@ -0,0 +1,2 @@
+---
+---

packages/integration-tests/src/process-controller/predicated_action_macros.ts

@@ -1,4 +1,5 @@
 import { PredicatedActionBuilder } from './predicated_action_queue_builder.js';
+import { PlatformDeploymentThresholds } from '../test-project-setup/test_project_base.js';
 
 /**
  * Convenience predicated actions that can be used to build up more complex CLI flows.
@@ -57,8 +58,12 @@ export const interruptSandbox = () => waitForSandboxToBecomeIdle().sendCtrlC();
  * Reusable predicated action: Wait for sandbox to finish deployment and assert that the deployment time is less
  * than the threshold.
  */
-export const ensureDeploymentTimeLessThan = (seconds: number) => {
+export const ensureDeploymentTimeLessThan = (
+  platformThresholds: PlatformDeploymentThresholds
+) => {
   return waitForSandboxDeploymentToPrintTotalTime().ensureDeploymentTimeLessThan(
-    seconds
+    process.platform.startsWith('win')
+      ? platformThresholds.onWindows
+      : platformThresholds.onOther
   );
 };

packages/integration-tests/src/test-project-setup/data_storage_auth_with_triggers.ts

@@ -133,7 +133,10 @@ class DataStorageAuthWithTriggerTestProject extends TestProjectBase {
       {
         sourceFile: sourceDataResourceFile,
         projectFile: dataResourceFile,
-        deployThresholdSec: 30,
+        deployThresholdSec: {
+          onWindows: 40,
+          onOther: 30,
+        },
       },
     ];
   }

packages/integration-tests/src/test-project-setup/test_project_base.ts

@@ -19,13 +19,23 @@ import {
 import fsp from 'fs/promises';
 import assert from 'node:assert';
 
+export type PlatformDeploymentThresholds = {
+  onWindows: number;
+  onOther: number;
+};
+
 /**
  * Keeps test project update info.
  */
 export type TestProjectUpdate = {
   sourceFile: URL;
   projectFile: URL;
-  deployThresholdSec: number;
+  /**
+   * Define a threshold for the hotswap deployment time
+   * Windows has a separate threshold because it is consistently slower than other platforms
+   * https://github.com/microsoft/Windows-Dev-Performance/issues/17
+   */
+  deployThresholdSec: PlatformDeploymentThresholds;
 };
 
 /**