Skip to content

Commit c802c7c

Browse files
committed
rename ephemeralStorageSize to ephemeralStorageSizeMB
1 parent 6594212 commit c802c7c

File tree

4 files changed

+22
-22
lines changed

4 files changed

+22
-22
lines changed

.changeset/nasty-tables-heal.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
'@aws-amplify/backend-function': minor
33
---
44

5-
Add ephemeralStorageSize option to defineFunction
5+
Add ephemeralStorageSizeMB option to defineFunction

packages/backend-function/API.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ export type FunctionProps = {
9393
entry?: string;
9494
timeoutSeconds?: number;
9595
memoryMB?: number;
96-
ephemeralStorageSize?: number;
96+
ephemeralStorageSizeMB?: number;
9797
environment?: Record<string, string | BackendSecret>;
9898
runtime?: NodeVersion;
9999
schedule?: FunctionSchedule | FunctionSchedule[];

packages/backend-function/src/factory.test.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -683,11 +683,11 @@ void describe('AmplifyFunctionFactory', () => {
683683
);
684684
});
685685

686-
void describe('ephemeralStorageSize property', () => {
686+
void describe('ephemeralStorageSizeMB property', () => {
687687
void it('sets valid ephemeralStorageSize', () => {
688688
const lambda = defineFunction({
689689
entry: './test-assets/default-lambda/handler.ts',
690-
ephemeralStorageSize: 1024,
690+
ephemeralStorageSizeMB: 1024,
691691
}).getInstance(getInstanceProps);
692692
const template = Template.fromStack(lambda.stack);
693693

@@ -696,7 +696,7 @@ void describe('AmplifyFunctionFactory', () => {
696696
});
697697
});
698698

699-
void it('sets default ephemeralStorageSize', () => {
699+
void it('sets default ephemeralStorageSizeMB', () => {
700700
const lambda = defineFunction({
701701
entry: './test-assets/default-lambda/handler.ts',
702702
}).getInstance(getInstanceProps);
@@ -707,41 +707,41 @@ void describe('AmplifyFunctionFactory', () => {
707707
});
708708
});
709709

710-
void it('throws on ephemeralStorageSize below 512 MB', () => {
710+
void it('throws on ephemeralStorageSizeMB below 512 MB', () => {
711711
assert.throws(
712712
() =>
713713
defineFunction({
714714
entry: './test-assets/default-lambda/handler.ts',
715-
ephemeralStorageSize: 511,
715+
ephemeralStorageSizeMB: 511,
716716
}).getInstance(getInstanceProps),
717717
new Error(
718-
'ephemeralStorageSize must be a whole number between 512 and 10240 inclusive'
718+
'ephemeralStorageSizeMB must be a whole number between 512 and 10240 inclusive'
719719
)
720720
);
721721
});
722722

723-
void it('throws on ephemeralStorageSize above 10240 MB', () => {
723+
void it('throws on ephemeralStorageSizeMB above 10240 MB', () => {
724724
assert.throws(
725725
() =>
726726
defineFunction({
727727
entry: './test-assets/default-lambda/handler.ts',
728-
ephemeralStorageSize: 10241,
728+
ephemeralStorageSizeMB: 10241,
729729
}).getInstance(getInstanceProps),
730730
new Error(
731-
'ephemeralStorageSize must be a whole number between 512 and 10240 inclusive'
731+
'ephemeralStorageSizeMB must be a whole number between 512 and 10240 inclusive'
732732
)
733733
);
734734
});
735735

736-
void it('throws on fractional ephemeralStorageSize', () => {
736+
void it('throws on fractional ephemeralStorageSizeMB', () => {
737737
assert.throws(
738738
() =>
739739
defineFunction({
740740
entry: './test-assets/default-lambda/handler.ts',
741-
ephemeralStorageSize: 512.5,
741+
ephemeralStorageSizeMB: 512.5,
742742
}).getInstance(getInstanceProps),
743743
new Error(
744-
'ephemeralStorageSize must be a whole number between 512 and 10240 inclusive'
744+
'ephemeralStorageSizeMB must be a whole number between 512 and 10240 inclusive'
745745
)
746746
);
747747
});

packages/backend-function/src/factory.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -116,11 +116,11 @@ export type FunctionProps = {
116116
memoryMB?: number;
117117

118118
/**
119-
* The size of the function's /tmp directory in MiB.
119+
* The size of the function's /tmp directory in MB.
120120
* Must be a whole number.
121121
* @default 512
122122
*/
123-
ephemeralStorageSize?: number;
123+
ephemeralStorageSizeMB?: number;
124124

125125
/**
126126
* Environment variables that will be available during function execution
@@ -243,7 +243,7 @@ class FunctionFactory implements ConstructFactory<AmplifyFunction> {
243243
entry: this.resolveEntry(),
244244
timeoutSeconds: this.resolveTimeout(),
245245
memoryMB: this.resolveMemory(),
246-
ephemeralStorageSize: this.resolveEphemeralStorageSize(),
246+
ephemeralStorageSizeMB: this.resolveEphemeralStorageSize(),
247247
environment: this.resolveEnvironment(),
248248
runtime: this.resolveRuntime(),
249249
schedule: this.resolveSchedule(),
@@ -336,21 +336,21 @@ class FunctionFactory implements ConstructFactory<AmplifyFunction> {
336336
const ephemeralStorageSizeMin = 512;
337337
const ephemeralStorageSizeMax = 10240;
338338
const ephemeralStorageSizeDefault = 512;
339-
if (this.props.ephemeralStorageSize === undefined) {
339+
if (this.props.ephemeralStorageSizeMB === undefined) {
340340
return ephemeralStorageSizeDefault;
341341
}
342342
if (
343343
!isWholeNumberBetweenInclusive(
344-
this.props.ephemeralStorageSize,
344+
this.props.ephemeralStorageSizeMB,
345345
ephemeralStorageSizeMin,
346346
ephemeralStorageSizeMax
347347
)
348348
) {
349349
throw new Error(
350-
`ephemeralStorageSize must be a whole number between ${ephemeralStorageSizeMin} and ${ephemeralStorageSizeMax} inclusive`
350+
`ephemeralStorageSizeMB must be a whole number between ${ephemeralStorageSizeMin} and ${ephemeralStorageSizeMax} inclusive`
351351
);
352352
}
353-
return this.props.ephemeralStorageSize;
353+
return this.props.ephemeralStorageSizeMB;
354354
};
355355

356356
private resolveEnvironment = () => {
@@ -538,7 +538,7 @@ class AmplifyFunction
538538
entry: props.entry,
539539
timeout: Duration.seconds(props.timeoutSeconds),
540540
memorySize: props.memoryMB,
541-
ephemeralStorageSize: Size.mebibytes(props.ephemeralStorageSize),
541+
ephemeralStorageSize: Size.mebibytes(props.ephemeralStorageSizeMB),
542542
runtime: nodeVersionMap[props.runtime],
543543
layers: props.resolvedLayers,
544544
bundling: {

0 commit comments

Comments
 (0)