Catch "stack is in failed state, you may need to delete it from AWS Console" (DELETE_FAILED) (#2265)

* delete stack regex

* test for cloud deletion error

* added changeset

* making some adjustments

* added stack name to error message

* update resolution message with failed resources

---------

Co-authored-by: Vieltojarvi <[email protected]>

Author: ShadowCat567

.changeset/chatty-goats-smell.md

@@ -0,0 +1,5 @@
+---
+'@aws-amplify/backend-deployer': patch
+---
+
+map a form of deletion/destroy failed error

packages/backend-deployer/src/cdk_error_mapper.test.ts

@@ -575,6 +575,13 @@ npm error enoent`,
     errorName: 'CommonNPMError',
     expectedDownstreamErrorMessage: undefined,
   },
+  {
+    errorMessage: `[31m: destroy failed Error: The stack named amplify-some-stack is in a failed state. You may need to delete it from the AWS console : DELETE_FAILED (The following resource(s) failed to delete: [resource1, resource2]. )`,
+    expectedTopLevelErrorMessage:
+      'The CloudFormation deletion failed due to amplify-some-stack being in DELETE_FAILED state. Ensure all your resources are able to be deleted',
+    errorName: 'CloudFormationDeletionError',
+    expectedDownstreamErrorMessage: undefined,
+  },
 ];
 
 void describe('invokeCDKCommand', { concurrency: 1 }, () => {

packages/backend-deployer/src/cdk_error_mapper.ts

@@ -211,6 +211,17 @@ export class CdkErrorMapper {
       errorName: 'GetLambdaLayerVersionError',
       classification: 'ERROR',
     },
+    {
+      //This has some overlap with "User:__ is not authorized to perform:__ on resource: __" - some resources cannot be deleted due to lack of permissions
+      errorRegex:
+        /The stack named (?<stackName>.*) is in a failed state. You may need to delete it from the AWS console : DELETE_FAILED \(The following resource\(s\) failed to delete: (?<resources>.*). \)/,
+      humanReadableErrorMessage:
+        'The CloudFormation deletion failed due to {stackName} being in DELETE_FAILED state. Ensure all your resources are able to be deleted',
+      resolutionMessage:
+        'The following resource(s) failed to delete: {resources}. Ensure they are in a state where they can be deleted. Find more information in the CloudFormation AWS Console for this stack.',
+      errorName: 'CloudFormationDeletionError',
+      classification: 'ERROR',
+    },
     {
       errorRegex:
         /User:(.*) is not authorized to perform:(.*) on resource:(?<resource>.*) because no identity-based policy allows the (?<action>.*) action/,
@@ -439,6 +450,7 @@ export type CDKDeploymentError =
   | 'CDKResolveAWSAccountError'
   | 'CDKVersionMismatchError'
   | 'CFNUpdateNotSupportedError'
+  | 'CloudFormationDeletionError'
   | 'CloudFormationDeploymentError'
   | 'CommonNPMError'
   | 'FilePermissionsError'