Skip to content

Commit d6b9286

Browse files
authored
adjust spinner time to ensure it renders deterministic amount of time (#2705)
1 parent 444c638 commit d6b9286

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

.changeset/quick-pillows-type.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@aws-amplify/cli-core': patch
3+
---
4+
5+
adjust spinner time to ensure it renders deterministic amount of time

packages/cli-core/src/printer/printer.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -139,18 +139,18 @@ void describe('Printer', () => {
139139
void it('startSpinner start animating spinner with message until stopSpinner is called in TTY terminal', async () => {
140140
const message = 'Message 1';
141141

142-
// Refresh rate of 100 ms
142+
// Refresh rate of 500 ms to avoid flakiness in tests
143143
const printer = new Printer(
144144
LogLevel.INFO,
145145
ttyStream,
146146
process.stderr,
147-
100,
147+
500,
148148
true,
149149
);
150150
printer.startSpinner(message);
151151

152-
// Wait for 400 ms
153-
await new Promise((resolve) => setTimeout(resolve, 400));
152+
// Wait for 1900 ms which should guarantee spinner outputting exactly 4 times at 0, 500, 1000, 1500
153+
await new Promise((resolve) => setTimeout(resolve, 1900));
154154

155155
// Stop spinner
156156
printer.stopSpinner();

0 commit comments

Comments
 (0)