adjustments

Author: ShadowCat567

package-lock.json

@@ -47,6 +47,8 @@ void describe('sandbox seed command', () => {
     () => null,
   );
 
+  const mockProfileResolver = mock.fn();
+
   let amplifySeedDir: string;
   let fullPath: string;
 
@@ -57,6 +59,7 @@ void describe('sandbox seed command', () => {
   before(async () => {
     const sandboxFactory = new SandboxSingletonFactory(
       () => Promise.resolve(testBackendId),
+      mockProfileResolver,
       printer,
       format,
     );
@@ -102,7 +105,6 @@ void describe('sandbox seed command', () => {
       }
     });
 
-    // this is deceptively hard to test because mocking open/read did not work on Linux/Mac
     void it('runs seed if seed script is found', async () => {
       const output = await commandRunner.runCommand('sandbox seed');
 
@@ -135,7 +137,6 @@ void describe('sandbox seed command', () => {
       await assert.rejects(
         () => commandRunner.runCommand('sandbox seed'),
         (err: TestCommandError) => {
-          // file differences between Unix and Windows makes it tricky to add the path
           assert.match(err.output, /SeedScriptNotFoundError/);
           assert.match(err.output, /There is no file that corresponds to/);
           assert.match(

packages/cli/src/commands/sandbox/sandbox-seed/sandbox_seed_command.test.ts

@@ -36,7 +36,7 @@ export class SandboxSeedCommand implements CommandModule<object> {
    * @inheritDoc
    */
   handler = async (): Promise<void> => {
-    printer.startSpinner('runSeedSpinner', '');
+    printer.startSpinner('');
     const backendID = await this.backendIDResolver.resolve();
     const seedPath = path.join('amplify', 'seed', 'seed.ts');
     try {
@@ -48,10 +48,10 @@ export class SandboxSeedCommand implements CommandModule<object> {
         },
       });
     } catch (err) {
-      printer.stopSpinner('runSeedSpinner');
+      printer.stopSpinner();
       throw err;
     }
-    printer.stopSpinner('runSeedSpinner');
+    printer.stopSpinner();
     printer.printNewLine();
     printer.print(`${format.success('✔')} seed has successfully completed`);
   };
@@ -63,7 +63,6 @@ export class SandboxSeedCommand implements CommandModule<object> {
     return yargs.command(this.seedSubCommands).check(() => {
       const seedPath = path.join(process.cwd(), 'amplify', 'seed', 'seed.ts');
       if (!existsSync(seedPath)) {
-        // this only gets sent to outputs
         throw new AmplifyUserError('SeedScriptNotFoundError', {
           message: `There is no file that corresponds to ${seedPath}`,
           resolution: `Please make a file that corresponds to ${seedPath} and put your seed logic in it`,

packages/cli/src/commands/sandbox/sandbox-seed/sandbox_seed_command.ts

@@ -7,10 +7,6 @@ import { Blob } from 'buffer';
 global.fetch = fetch as never;
 global.Blob = Blob as never;
 
-// node 16 does not include Blob, so we need to polyfill it
-import { Blob } from 'node-fetch';
-global.Blob = Blob as never;
-
 /**
  * Dummy lambda handler to test building a function with a local import
  */

packages/integration-tests/src/test-projects/data-storage-auth-with-triggers-ts/amplify/func-src/handler_node16.ts

@@ -143,7 +143,7 @@ void describe('seeding auth APIs', () => {
     });
   });
 
-  // this is also where the tests that apply to all createAndSignUp user flows go
+  // encompasses tests that apply to all createAndSignUpUser flows
   void describe('userpool configured without MFA', () => {
     const mockConfigReader = {
       getAuthConfig: mock.fn<() => Promise<AuthConfiguration>>(async () =>