Skip to content

Commit e25e96b

Browse files
authored
relax cdk linked dependency constraint (#2542)
* relax cdk linked dependency constraint * PR updates
1 parent 5700572 commit e25e96b

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

.changeset/nasty-rivers-invent.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

scripts/check_dependencies.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,6 @@ await new DependenciesValidator(
2121
],
2222
},
2323
},
24-
[['aws-cdk', 'aws-cdk-lib']],
24+
[], // Add a list of dependencies here that should be versioned together
2525
[]
2626
).validate();

scripts/components/dependencies_validator.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ void describe('Dependency validator', () => {
292292
await new DependenciesValidator(
293293
packagePaths,
294294
{},
295-
[['aws-cdk', 'aws-cdk-lib']],
295+
[['dep-1', 'dep-2']],
296296
[],
297297
execaMock as never
298298
).validate();
@@ -301,8 +301,8 @@ void describe('Dependency validator', () => {
301301
assert.ok(
302302
err.message.includes('should be declared using same version')
303303
);
304-
assert.ok(err.message.includes('aws-cdk'));
305-
assert.ok(err.message.includes('aws-cdk-lib'));
304+
assert.ok(err.message.includes('dep-1'));
305+
assert.ok(err.message.includes('dep-2'));
306306
return true;
307307
}
308308
);
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "package1",
33
"dependencies": {
4-
"aws-cdk-lib": "^2.117.0"
4+
"dep-1": "^2.117.0"
55
}
66
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "package2",
33
"dependencies": {
4-
"aws-cdk": "^2.127.0"
4+
"dep-2": "^2.127.0"
55
}
66
}

0 commit comments

Comments
 (0)