chore: move ulimit increase to per-step execution in CI workflows (#3004)

chore: increase ulimit per shell

Author: mrgrain

.github/workflows/health_checks.yml

@@ -150,10 +150,6 @@ jobs:
     timeout-minutes: 15
     steps:
       - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
-      - name: Increase ulimit
-        if: runner.os == 'macOS'
-        run: |
-          ulimit -n 10000
       - uses: ./.github/actions/setup_node
         with:
           node-version: ${{ matrix.node }}
@@ -482,10 +478,6 @@ jobs:
       contents: read
     steps:
       - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
-      - name: Increase ulimit
-        if: runner.os == 'macOS'
-        run: |
-          ulimit -n 10000
       - name: Run e2e deployment tests
         uses: ./.github/actions/run_with_e2e_account
         with:
@@ -494,6 +486,7 @@ jobs:
           cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
           link_cli: true
           run: |
+            [[ "$RUNNER_OS" == "macOS" ]] && ulimit -n 10000
             npm run test:dir ${{ matrix.testPaths }}
   e2e_generate_sandbox_tests_matrix:
     if: needs.do_include_e2e.outputs.run_e2e == 'true'
@@ -534,18 +527,16 @@ jobs:
       contents: read
     steps:
       - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
-      - name: Increase ulimit
-        if: runner.os == 'macOS'
-        run: |
-          ulimit -n 10000
       - name: Run e2e sandbox tests
         uses: ./.github/actions/run_with_e2e_account
         with:
           e2e_test_accounts: ${{ vars.E2E_TEST_ACCOUNTS }}
           node_version: ${{ matrix.node-version }}
           cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
           link_cli: true
-          run: npm run test:dir ${{ matrix.testPaths }}
+          run: |
+            [[ "$RUNNER_OS" == "macOS" ]] && ulimit -n 10000
+            npm run test:dir ${{ matrix.testPaths }}
   e2e_notices:
     if: needs.do_include_e2e.outputs.run_e2e == 'true'
     strategy:
@@ -566,10 +557,6 @@ jobs:
       contents: read
     steps:
       - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
-      - name: Increase ulimit
-        if: runner.os == 'macOS'
-        run: |
-          ulimit -n 10000
       - uses: ./.github/actions/setup_node
         with:
           node-version: 18
@@ -579,7 +566,9 @@ jobs:
           cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
       - run: cd packages/cli && npm link
       - name: Run e2e notices tests
-        run: npm run test:dir packages/integration-tests/lib/test-e2e/notices.test.js
+        run: |
+          [[ "$RUNNER_OS" == "macOS" ]] && ulimit -n 10000
+          npm run test:dir packages/integration-tests/lib/test-e2e/notices.test.js
   e2e_backend_output:
     if: needs.do_include_e2e.outputs.run_e2e == 'true'
     runs-on: ubuntu-latest
@@ -628,10 +617,6 @@ jobs:
       - resolve_inputs
     steps:
       - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
-      - name: Increase ulimit
-        if: runner.os == 'macOS'
-        run: |
-          ulimit -n 10000
       - uses: ./.github/actions/setup_node
         with:
           node-version: ${{ matrix.node-version }}
@@ -641,7 +626,9 @@ jobs:
           cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
       - run: cd packages/cli && npm link
       - name: Run e2e create-amplify tests
-        run: npm run test:dir packages/integration-tests/lib/test-e2e/create_amplify.test.js
+        run: |
+          [[ "$RUNNER_OS" == "macOS" ]] && ulimit -n 10000
+          npm run test:dir packages/integration-tests/lib/test-e2e/create_amplify.test.js
   e2e_package_manager:
     if: needs.do_include_e2e.outputs.run_e2e == 'true' && needs.do_include_e2e.outputs.include_package_manager_e2e == 'true'
     strategy:
@@ -664,10 +651,6 @@ jobs:
       id-token: write
       contents: read
     steps:
-      - name: Increase ulimit
-        if: runner.os == 'macOS'
-        run: |
-          ulimit -n 10000
       - name: Checkout aws-amplify/amplify-backend repo
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - name: Run E2E flow tests with ${{ matrix.pkg-manager }}
@@ -678,6 +661,7 @@ jobs:
           cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
           shell: bash
           run: |
+            [[ "$RUNNER_OS" == "macOS" ]] && ulimit -n 10000
             PACKAGE_MANAGER=${{matrix.pkg-manager}} npm run test:dir packages/integration-tests/src/package_manager_sanity_checks.test.ts
   lint:
     runs-on: ubuntu-latest