fix: validate input stack name for generate commands (#2299)

* fix: validate input stack name for generate commands

* lint fix

Author: Amplifiyer

.changeset/shy-ladybugs-buy.md

@@ -0,0 +1,5 @@
+---
+'@aws-amplify/backend-cli': patch
+---
+
+validate input stack name for generate commands

packages/cli/src/commands/generate/generate_command.ts

@@ -4,6 +4,7 @@ import { GenerateFormsCommand } from './forms/generate_forms_command.js';
 import { GenerateGraphqlClientCodeCommand } from './graphql-client-code/generate_graphql_client_code_command.js';
 import { CommandMiddleware } from '../../command_middleware.js';
 import { GenerateSchemaCommand } from './schema-from-database/generate_schema_command.js';
+import { AmplifyUserError } from '@aws-amplify/platform-core';
 
 /**
  * An entry point for generate command.
@@ -62,6 +63,20 @@ export class GenerateCommand implements CommandModule {
           type: 'string',
           array: false,
         })
+        .check(async (argv) => {
+          const stackNameRegex =
+            /^[a-zA-Z][-a-zA-Z0-9]{1,127}$|^arn:[-a-zA-Z0-9:/._+]$/;
+          if (argv['stack'] && typeof argv['stack'] === 'string') {
+            if (!argv.stack.match(stackNameRegex)) {
+              throw new AmplifyUserError('InvalidCommandInputError', {
+                message: `Invalid --stack name provided: ${argv.stack}`,
+                resolution:
+                  'Check the value of the stack name provided and try again.',
+              });
+            }
+          }
+          return true;
+        })
         .middleware([this.commandMiddleware.ensureAwsCredentialAndRegion])
     );
   };

packages/cli/src/commands/generate/generate_command_factory.test.ts

@@ -1,7 +1,10 @@
 import yargs from 'yargs';
 import { describe, it } from 'node:test';
 import assert from 'node:assert';
-import { TestCommandRunner } from '../../test-utils/command_runner.js';
+import {
+  TestCommandError,
+  TestCommandRunner,
+} from '../../test-utils/command_runner.js';
 import { createGenerateCommand } from './generate_command_factory.js';
 
 /**
@@ -31,6 +34,20 @@ void describe('top level generate command', () => {
     assert.match(output, /Not enough non-option arguments/);
   });
 
+  void it('fails if stack argument provided is invalid', async () => {
+    await assert.rejects(
+      () => commandRunner.runCommand('generate outputs --stack 3-Invalid'),
+      (error: TestCommandError) => {
+        assert.strictEqual(error.error.name, 'InvalidCommandInputError');
+        assert.strictEqual(
+          error.error.message,
+          'Invalid --stack name provided: 3-Invalid'
+        );
+        return true;
+      }
+    );
+  });
+
   void it('should throw if top level command handler is ever called', () => {
     assert.throws(
       () => generateCommand.handler({ $0: '', _: [] }),