Skip to content

feat(data): support adopt option for migratedAmplifyGen1DynamoDbTable Mappings; ADOPTED strategy and data-construct adoption #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(data): support adopt option for migratedAmplifyGen1DynamoDbTable Mappings; ADOPTED strategy and data-construct adoption #3039

wants to merge 1 commit into from

Conversation

@iankhou
Copy link
Contributor

@iankhou iankhou commented Oct 29, 2025

Problem

Issue number, if available:

Changes

Corresponding docs PR, if applicable:

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iankhou
feat(data): support adopt option for migratedAmplifyGen1DynamoDbTable…
73da2d0 
…Mappings; ADOPTED strategy and data-construct adoption
@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

⚠️ No Changeset found

Latest commit: 73da2d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 29, 2025
View reviewed changes
packages/backend-data/src/types.ts
| string
| DerivedModelSchema
| DerivedCombinedSchema;
import { LogLevel } from '@aws-amplify/plugin-types';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import LogLevel.

Copilot Autofix

AI 24 days ago

To resolve this issue, we should remove the unused import for LogLevel on line 4 in the file packages/backend-data/src/types.ts. This involves deleting the line import { LogLevel } from '@aws-amplify/plugin-types'; while leaving other imports (if any) untouched. This change will reduce clutter and prevent potential confusion, and will not affect any visible functionality since the symbol was not used in this file.

Suggested changeset 1
packages/backend-data/src/types.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/backend-data/src/types.ts b/packages/backend-data/src/types.ts
--- a/packages/backend-data/src/types.ts
+++ b/packages/backend-data/src/types.ts
@@ -1,7 +1,6 @@
 // packages/backend-data/src/types.ts
 // (Modified to support ImportedTableConfig and adoption option)
 
-import { LogLevel } from '@aws-amplify/plugin-types';
 
 /**
  * Schema type definition, can be either a raw Graphql string, or a typed model schema.
EOF
@@ -1,7 +1,6 @@
// packages/backend-data/src/types.ts
// (Modified to support ImportedTableConfig and adoption option)

import { LogLevel } from '@aws-amplify/plugin-types';

/**
* Schema type definition, can be either a raw Graphql string, or a typed model schema.
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@iankhou