Skip to content

Commit 35b3563

Browse files
Kamil Sobolawsluja
authored andcommitted
fix: failing env init when user pool is defined (#11225)
* fix: failing env init when user pool is defined * fix: e2e test * fix: e2e test * fix: this works
1 parent c8d695a commit 35b3563

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

packages/amplify-category-auth/src/provider-utils/awscloudformation/utils/synthesize-resources.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -287,9 +287,9 @@ export const updateUserPoolGroups = async (context: $TSContext, resourceName: st
287287
context.amplify.updateamplifyMetaAfterResourceUpdate(AmplifyCategories.AUTH, 'userPoolGroups', 'service', 'Cognito-UserPool-Groups');
288288
context.amplify.updateamplifyMetaAfterResourceUpdate(AmplifyCategories.AUTH, 'userPoolGroups', 'providerPlugin', 'awscloudformation');
289289

290-
const authParameters = stateManager.getResourceParametersJson(undefined, AmplifyCategories.AUTH, resourceName);
290+
const authInputs = stateManager.getResourceInputsJson(undefined, AmplifyCategories.AUTH, resourceName);
291291
const attributes = ['UserPoolId', 'AppClientIDWeb', 'AppClientID'];
292-
if (authParameters?.identityPoolName) {
292+
if (authInputs?.cognitoConfig?.identityPoolName) {
293293
attributes.push('IdentityPoolId');
294294
}
295295
context.amplify.updateamplifyMetaAfterResourceUpdate(AmplifyCategories.AUTH, 'userPoolGroups', 'dependsOn', [

packages/amplify-e2e-tests/src/__tests__/init-special-case.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
getTeamProviderInfo,
1111
initJSProjectWithProfile,
1212
transformCurrentProjectToGitPulledProject,
13+
updateAuthAddUserGroups,
1314
updatedInitNewEnvWithProfile,
1415
} from '@aws-amplify/amplify-e2e-core';
1516
import * as specialCaseInit from '../init-special-cases';
@@ -42,6 +43,7 @@ describe('amplify init', () => {
4243
const resourceName = 'authConsoleTest';
4344
await initJSProjectWithProfile(projectRoot, { disableAmplifyAppCreation: false, name: resourceName, envName });
4445
await addAuthWithDefault(projectRoot, {});
46+
await updateAuthAddUserGroups(projectRoot, ['group']);
4547
await amplifyPushAuth(projectRoot);
4648
const teamInfo = getTeamProviderInfo(projectRoot);
4749
expect(teamInfo).toBeDefined();

0 commit comments

Comments
 (0)