fix: missing targetNames in hasOne reference

AaronZyLee · AaronZyLee · commit 02a581f6a970 · 2024-04-16T17:47:52.000-07:00
diff --git a/packages/appsync-modelgen-plugin/src/__tests__/visitors/__snapshots__/appsync-model-introspection-visitor.test.ts.snap b/packages/appsync-modelgen-plugin/src/__tests__/visitors/__snapshots__/appsync-model-introspection-visitor.test.ts.snap
@@ -3692,7 +3692,8 @@ exports[`custom references double linked references 1`] = `
                         \\"connectionType\\": \\"HAS_ONE\\",
                         \\"associatedWith\\": [
                             \\"bar1Id\\"
-                        ]
+                        ],
+                        \\"targetNames\\": []
                     }
                 },
                 \\"bar2\\": {
@@ -3707,7 +3708,8 @@ exports[`custom references double linked references 1`] = `
                         \\"connectionType\\": \\"HAS_ONE\\",
                         \\"associatedWith\\": [
                             \\"bar2Id\\"
-                        ]
+                        ],
+                        \\"targetNames\\": []
                     }
                 },
                 \\"createdAt\\": {
@@ -4244,7 +4246,8 @@ exports[`custom references sets the association to the references field for hasO
                         \\"connectionType\\": \\"HAS_ONE\\",
                         \\"associatedWith\\": [
                             \\"primaryId\\"
-                        ]
+                        ],
+                        \\"targetNames\\": []
                     }
                 },
                 \\"createdAt\\": {
@@ -4467,7 +4470,8 @@ exports[`custom references sets the association to the references field for hasO
                         \\"connectionType\\": \\"HAS_ONE\\",
                         \\"associatedWith\\": [
                             \\"primaryId\\"
-                        ]
+                        ],
+                        \\"targetNames\\": []
                     }
                 },
                 \\"createdAt\\": {
diff --git a/packages/appsync-modelgen-plugin/src/visitors/appsync-model-introspection-visitor.ts b/packages/appsync-modelgen-plugin/src/visitors/appsync-model-introspection-visitor.ts
@@ -115,7 +115,7 @@ export class AppSyncModelIntrospectionVisitor<
         connectionAttribute.associatedWith = connectionInfo.associatedWithFields.map(f => this.getFieldName(f));
       } else if (connectionInfo.kind === CodeGenConnectionType.HAS_ONE) {
           connectionAttribute.associatedWith = connectionInfo.associatedWithFields.map(f => this.getFieldName(f));
-          connectionAttribute.targetNames = connectionInfo.targetNames;
+          connectionAttribute.targetNames = connectionInfo.targetNames ?? [];
       } else {
         connectionAttribute.targetNames = connectionInfo.targetNames;
       }

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ export class AppSyncModelIntrospectionVisitor<`
`115`	`115`	`connectionAttribute.associatedWith = connectionInfo.associatedWithFields.map(f => this.getFieldName(f));`
`116`	`116`	`} else if (connectionInfo.kind === CodeGenConnectionType.HAS_ONE) {`
`117`	`117`	`connectionAttribute.associatedWith = connectionInfo.associatedWithFields.map(f => this.getFieldName(f));`
`118`		`- connectionAttribute.targetNames = connectionInfo.targetNames;`
	`118`	`+ connectionAttribute.targetNames = connectionInfo.targetNames ?? [];`
`119`	`119`	`} else {`
`120`	`120`	`connectionAttribute.targetNames = connectionInfo.targetNames;`
`121`	`121`	`}`