Skip to content

Commit aab5e7d

Browse files
Merge pull request #293 from marcvberg/hasone-nonnull-field-fix
Hasone nonnull field fix
2 parents 9716c47 + 424308a commit aab5e7d

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

packages/appsync-modelgen-plugin/src/__tests__/visitors/appsync-visitor.test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,8 +339,9 @@ describe('AppSyncModelVisitor', () => {
339339
);
340340
visit(ast, { leave: visitor });
341341
visitor.generate();
342-
const projectFields = visitor.models.Project.fields.map(field => field.name);
343-
expect(projectFields).toContain('projectTeamId');
342+
const projectTeamIdField = visitor.models.Project.fields.find(field => { return field.name === 'projectTeamId'; });
343+
expect(projectTeamIdField).toBeDefined();
344+
expect(projectTeamIdField.isNullable).toBeTruthy();
344345
});
345346
});
346347

packages/appsync-modelgen-plugin/src/visitors/appsync-visitor.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -691,7 +691,7 @@ export class AppSyncModelVisitor<
691691
directives: [],
692692
type: 'ID',
693693
isList: false,
694-
isNullable: connectionInfo.associatedWith.isNullable,
694+
isNullable: field.isNullable,
695695
});
696696
} else if (connectionInfo.targetName !== 'id') {
697697
// Need to remove the field that is targetName

0 commit comments

Comments
 (0)