fix: support pre-release version tags for dart version check (#477)

Author: alharris-at

packages/amplify-codegen/src/utils/validateDartSDK.js

@@ -9,7 +9,7 @@ function validateDartSDK(context, projectRoot) {
   try {
     const config = yaml.load(fs.readFileSync(path.join(projectRoot, PUBSPEC_FILE_NAME), 'utf8'));
     const version = semver.minVersion(config.environment.sdk);
-    if (semver.satisfies(version, '>= 2.12.0')) {
+    if (semver.satisfies(version, '>= 2.12.0', { includePrerelease: true })) {
       context.print.warning('\nDetected Dart SDK version 2.12.0 or above');
       return true;
     }

packages/amplify-codegen/tests/utils/validateDartSDK.test.js

@@ -26,6 +26,7 @@ describe('Validate Dart SDK version tests', () => {
       mockFs({ [MOCK_PUBSPEC_FILE_PATH]: yaml.dump(config) });
       expect(validateDartSDK(MOCK_CONTEXT, MOCK_PROJECT_ROOT)).toBe(true);
     });
+
     it('with caret version', () => {
       const config = {
         environment: {
@@ -35,6 +36,17 @@ describe('Validate Dart SDK version tests', () => {
       mockFs({ [MOCK_PUBSPEC_FILE_PATH]: yaml.dump(config) });
       expect(validateDartSDK(MOCK_CONTEXT, MOCK_PROJECT_ROOT)).toBe(true);
     });
+
+    it('with preRelease caret version', () => {
+      const config = {
+        environment: {
+          sdk: '^2.18.0-release1',
+        },
+      };
+      mockFs({ [MOCK_PUBSPEC_FILE_PATH]: yaml.dump(config) });
+      expect(validateDartSDK(MOCK_CONTEXT, MOCK_PROJECT_ROOT)).toBe(true);
+    });
+
     it('with ranged version', () => {
       const config = {
         environment: {
@@ -44,6 +56,16 @@ describe('Validate Dart SDK version tests', () => {
       mockFs({ [MOCK_PUBSPEC_FILE_PATH]: yaml.dump(config) });
       expect(validateDartSDK(MOCK_CONTEXT, MOCK_PROJECT_ROOT)).toBe(true);
     });
+
+    it('with preRelease range', () => {
+      const config = {
+        environment: {
+          sdk: '>=2.18.0-release1 <3.0.0',
+        },
+      };
+      mockFs({ [MOCK_PUBSPEC_FILE_PATH]: yaml.dump(config) });
+      expect(validateDartSDK(MOCK_CONTEXT, MOCK_PROJECT_ROOT)).toBe(true);
+    });
   });
 
   describe('should return false if the minimum version is less than 2.12.0', () => {
@@ -56,6 +78,7 @@ describe('Validate Dart SDK version tests', () => {
       mockFs({ [MOCK_PUBSPEC_FILE_PATH]: yaml.dump(config) });
       expect(validateDartSDK(MOCK_CONTEXT, MOCK_PROJECT_ROOT)).toBe(false);
     });
+
     it('with caret version', () => {
       const config = {
         environment: {
@@ -65,6 +88,17 @@ describe('Validate Dart SDK version tests', () => {
       mockFs({ [MOCK_PUBSPEC_FILE_PATH]: yaml.dump(config) });
       expect(validateDartSDK(MOCK_CONTEXT, MOCK_PROJECT_ROOT)).toBe(false);
     });
+
+    it('with preRelease caret version', () => {
+      const config = {
+        environment: {
+          sdk: '^2.0.0-release1',
+        },
+      };
+      mockFs({ [MOCK_PUBSPEC_FILE_PATH]: yaml.dump(config) });
+      expect(validateDartSDK(MOCK_CONTEXT, MOCK_PROJECT_ROOT)).toBe(false);
+    });
+
     it('with ranged version', () => {
       const config = {
         environment: {
@@ -74,6 +108,16 @@ describe('Validate Dart SDK version tests', () => {
       mockFs({ [MOCK_PUBSPEC_FILE_PATH]: yaml.dump(config) });
       expect(validateDartSDK(MOCK_CONTEXT, MOCK_PROJECT_ROOT)).toBe(false);
     });
+
+    it('with preRelease range', () => {
+      const config = {
+        environment: {
+          sdk: '>=2.0.0-release1 <3.0.0',
+        },
+      };
+      mockFs({ [MOCK_PUBSPEC_FILE_PATH]: yaml.dump(config) });
+      expect(validateDartSDK(MOCK_CONTEXT, MOCK_PROJECT_ROOT)).toBe(false);
+    });
   });
 
   it('should return true if the sdk version cannot be found', () => {