Skip to content

Commit 9885396

Browse files
authored
chore(auth): remove token query parameters (#6179)
1 parent 2840db5 commit 9885396

File tree

7 files changed

+2
-52
lines changed

7 files changed

+2
-52
lines changed

packages/amplify_core/lib/src/config/amplify_outputs/auth/oauth_outputs.dart

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ class OAuthOutputs
2626
this.signOutUri,
2727
this.signOutUriQueryParameters,
2828
this.tokenUri,
29-
this.tokenUriQueryParameters,
3029
required this.responseType,
3130
});
3231

@@ -85,13 +84,6 @@ class OAuthOutputs
8584
@internal
8685
final String? tokenUri;
8786

88-
/// Optional query params in the OAuth token URI.
89-
///
90-
/// Note: This attribute is not part of the Amplify Outputs schema.
91-
/// This exists for backwards compatibility with the Gen 1 config.
92-
@internal
93-
final Map<String, String>? tokenUriQueryParameters;
94-
9587
/// {@macro amplify_core.amplify_outputs.oauth_response_type}
9688
final OAuthResponseType responseType;
9789

@@ -107,7 +99,6 @@ class OAuthOutputs
10799
signOutUri,
108100
signOutUriQueryParameters,
109101
tokenUri,
110-
tokenUriQueryParameters,
111102
responseType,
112103
];
113104

packages/amplify_core/lib/src/config/amplify_outputs/auth/oauth_outputs.g.dart

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/amplify_core/lib/src/config/auth/auth_config.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ class AuthConfig extends AmplifyPluginConfigMap {
126126
signOutUri: oAuthConfig.signOutUri,
127127
signOutUriQueryParameters: oAuthConfig.signOutUriQueryParameters,
128128
tokenUri: oAuthConfig.tokenUri,
129-
tokenUriQueryParameters: oAuthConfig.tokenUriQueryParameters,
130129
// Amplify Flutter only supports responseType:code
131130
// "response_type" is set to "code" by `getAuthorizationUrl` from
132131
// pkg:oauth2

packages/amplify_core/lib/src/config/auth/cognito/oauth.dart

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ class CognitoOAuthConfig
2626
this.tokenUri,
2727
this.signInUriQueryParameters,
2828
this.signOutUriQueryParameters,
29-
this.tokenUriQueryParameters,
3029
});
3130

3231
@internal
@@ -51,7 +50,6 @@ class CognitoOAuthConfig
5150
final signOutRedirectUri = authOutputs.oauth!.redirectSignOutUri.join(',');
5251
final webDomain = authOutputs.oauth!.domain;
5352
final tokenUri = authOutputs.oauth!.tokenUri;
54-
final tokenUriQueryParameters = authOutputs.oauth!.tokenUriQueryParameters;
5553

5654
return CognitoOAuthConfig(
5755
appClientId: appClientId,
@@ -65,7 +63,6 @@ class CognitoOAuthConfig
6563
signInUriQueryParameters: signInUriQueryParameters,
6664
signOutUriQueryParameters: signOutUriQueryParameters,
6765
tokenUri: tokenUri,
68-
tokenUriQueryParameters: tokenUriQueryParameters,
6966
);
7067
}
7168

@@ -103,9 +100,6 @@ class CognitoOAuthConfig
103100
@JsonKey(name: 'TokenURI')
104101
final String? tokenUri;
105102

106-
@JsonKey(name: 'TokenURIQueryParameters')
107-
final Map<String, String>? tokenUriQueryParameters;
108-
109103
final List<String> scopes;
110104

111105
@override
@@ -120,7 +114,6 @@ class CognitoOAuthConfig
120114
signOutUri,
121115
signOutUriQueryParameters,
122116
tokenUri,
123-
tokenUriQueryParameters,
124117
scopes,
125118
];
126119

@@ -135,7 +128,6 @@ class CognitoOAuthConfig
135128
String? signOutUri,
136129
Map<String, String>? signOutUriQueryParameters,
137130
String? tokenUri,
138-
Map<String, String>? tokenUriQueryParameters,
139131
List<String>? scopes,
140132
}) {
141133
return CognitoOAuthConfig(
@@ -157,11 +149,6 @@ class CognitoOAuthConfig
157149
? null
158150
: Map.of(this.signOutUriQueryParameters!)),
159151
tokenUri: tokenUri ?? this.tokenUri,
160-
tokenUriQueryParameters:
161-
tokenUriQueryParameters ??
162-
(this.tokenUriQueryParameters == null
163-
? null
164-
: Map.of(this.tokenUriQueryParameters!)),
165152
scopes: scopes ?? List.of(this.scopes),
166153
);
167154
}

packages/amplify_core/lib/src/config/auth/cognito/oauth.g.dart

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/amplify_core/test/config/amplify_outputs_mapping/amplify_outputs_mapping_test.dart

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,6 @@ void main() {
8181
signOutQueryParamKey: signOutQueryParamValue,
8282
});
8383
expect(oauth.tokenUri, tokenUri);
84-
expect(oauth.tokenUriQueryParameters, {
85-
tokenQueryParamKey: tokenQueryParamValue,
86-
});
8784
expect(oauth.scopes, containsAll([scope1, scope2]));
8885
});
8986

@@ -167,7 +164,7 @@ const scope2 = 'scope2';
167164

168165
/// hand written config with all oauth options including those not par of the
169166
/// AmplifyOutputs schema (SignInURIQueryParameters, SignOutURIQueryParameters,
170-
/// TokenURI, and TokenURIQueryParameters)
167+
/// and TokenURI)
171168
const oauthConfig =
172169
'''{
173170
"auth": {
@@ -196,9 +193,6 @@ const oauthConfig =
196193
"$signOutQueryParamKey": "$signOutQueryParamValue"
197194
},
198195
"TokenURI": "$tokenUri",
199-
"TokenURIQueryParameters": {
200-
"$tokenQueryParamKey": "$tokenQueryParamValue"
201-
},
202196
"Scopes": [
203197
"$scope1",
204198
"$scope2"

packages/auth/amplify_auth_cognito_dart/lib/src/flows/hosted_ui/hosted_ui_config.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,6 @@ extension HostedUiConfig on OAuthOutputs {
8282
} else {
8383
baseUri = _webDomain.replace(path: '/oauth2/token');
8484
}
85-
return baseUri.replace(
86-
// ignore: invalid_use_of_internal_member
87-
queryParameters: tokenUriQueryParameters,
88-
);
85+
return baseUri;
8986
}
9087
}

0 commit comments

Comments
 (0)