fix(aws_common): Close HTTP client when stream is done

Only close a client we created when the streaming of the response is complete, otherwise we may prematurely terminate the underlying connection.

commit-id:e4caee26

Author: Dillon Nys

packages/aws_common/lib/src/http/aws_http_request.dart

@@ -20,6 +20,7 @@ import 'package:async/async.dart';
 import 'package:aws_common/aws_common.dart';
 import 'package:http/http.dart' as http;
 import 'package:meta/meta.dart';
+import 'package:stream_transform/stream_transform.dart';
 
 /// {@template aws_common.aws_http_request}
 /// A parameterized HTTP request.
@@ -109,18 +110,30 @@ abstract class AWSBaseHttpRequest implements Closeable {
   /// If [client] is not provided, a short-lived one is created for this request.
   Future<AWSStreamedHttpResponse> send([http.Client? client]) async {
     final useClient = client ?? http.Client();
+
+    // Closes the HTTP client, but only if we created it.
+    void closeClient() {
+      if (client == null) {
+        useClient.close();
+      }
+    }
+
     try {
       final resp = await useClient.send(httpRequest);
       return AWSStreamedHttpResponse(
         headers: resp.headers,
         statusCode: resp.statusCode,
-        body: resp.stream,
+        body: resp.stream.tap(
+          null,
+          // Wait until the body has been read before closing the client,
+          // since chunked requests require that the client not be closed
+          // until they're complete.
+          onDone: closeClient,
+        ),
       );
-    } finally {
-      // Only close a client we created.
-      if (client == null) {
-        useClient.close();
-      }
+    } on Object {
+      closeClient();
+      rethrow;
     }
   }
 

packages/aws_common/pubspec.yaml

@@ -13,6 +13,7 @@ dependencies:
   collection: ^1.15.0
   http: ^0.13.4
   meta: ^1.7.0
+  stream_transform: ^2.0.0
   uuid: 3.0.6
 
 dev_dependencies: