Chore: Unpin eslint dependencies (#14305)

ashika112 · web-flow · commit 4d541d953955 · 2025-03-19T12:05:16.000-07:00
* unpin eslint

* running auto-fix

* missed update of node 20 in canaray
diff --git a/.github/actions/node-and-build/action.yml b/.github/actions/node-and-build/action.yml
@@ -7,7 +7,7 @@ inputs:
 runs:
   using: 'composite'
   steps:
-    - name: Setup Node.js 18
+    - name: Setup Node.js 20
       uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4.3.0
       with:
         node-version: 20
diff --git a/.github/workflows/callable-canary-e2e-tests.yml b/.github/workflows/callable-canary-e2e-tests.yml
@@ -58,10 +58,10 @@ jobs:
           # Minimal depth 2 so we can checkout the commit before possible merge commit.
           fetch-depth: 2
           path: amplify-js
-      - name: Setup Node.js 18
-        uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
+      - name: Setup Node.js 20
+        uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4.3.0
         with:
-          node-version: 18
+          node-version: 20
         env:
           SEGMENT_DOWNLOAD_TIMEOUT_MINS: 2
 
diff --git a/package.json b/package.json
@@ -92,10 +92,10 @@
 		"@types/lodash": "4.14.182",
 		"@types/node": "^8.9.5",
 		"@types/puppeteer": "1.3.0",
-		"@typescript-eslint/eslint-plugin": "8.8.1",
-		"@typescript-eslint/parser": "8.8.1",
+		"@typescript-eslint/eslint-plugin": "^8.8.1",
+		"@typescript-eslint/parser": "^8.8.1",
 		"babel-loader": "^8.3.0",
-		"eslint": "9.12.0",
+		"eslint": "^9.12.0",
 		"eslint-config-prettier": "^9.1.0",
 		"eslint-config-standard": "^17.1.0",
 		"eslint-import-resolver-typescript": "^3.6.3",
diff --git a/packages/adapter-nextjs/src/auth/utils/getCookieValuesFromNextApiRequest.ts b/packages/adapter-nextjs/src/auth/utils/getCookieValuesFromNextApiRequest.ts
@@ -5,9 +5,7 @@ import { NextApiRequest } from 'next';
 
 export const getCookieValuesFromNextApiRequest = <
 	CookieNames extends string[],
-	R = {
-		[key in CookieNames[number]]?: string | undefined;
-	},
+	R = Partial<Record<CookieNames[number], string | undefined>>,
 >(
 	request: NextApiRequest,
 	cookieNames: CookieNames,
diff --git a/packages/adapter-nextjs/src/auth/utils/getCookieValuesFromRequest.ts b/packages/adapter-nextjs/src/auth/utils/getCookieValuesFromRequest.ts
@@ -4,9 +4,7 @@
 export const getCookieValuesFromRequest = <CookieNames extends string[]>(
 	request: Request,
 	cookieNames: CookieNames,
-): {
-	[key in CookieNames[number]]?: string | undefined;
-} => {
+): Partial<Record<CookieNames[number], string | undefined>> => {
 	const cookieHeader = request.headers.get('Cookie');
 
 	if (!cookieHeader) {
@@ -27,7 +25,5 @@ export const getCookieValuesFromRequest = <CookieNames extends string[]>(
 		result[cookieName] = cookieValues[cookieName];
 	}
 
-	return result as {
-		[key in CookieNames[number]]?: string | undefined;
-	};
+	return result as Partial<Record<CookieNames[number], string | undefined>>;
 };
diff --git a/packages/auth/src/providers/cognito/tokenProvider/types.ts b/packages/auth/src/providers/cognito/tokenProvider/types.ts
@@ -20,9 +20,7 @@ export type TokenRefresher = ({
 	username: string;
 }) => Promise<CognitoAuthTokens>;
 
-export type AuthKeys<AuthKey extends string> = {
-	[Key in AuthKey]: string;
-};
+export type AuthKeys<AuthKey extends string> = Record<AuthKey, string>;
 
 export const AuthTokenStorageKeys = {
 	accessToken: 'accessToken',
diff --git a/packages/auth/src/types/Auth.ts b/packages/auth/src/types/Auth.ts
@@ -20,7 +20,7 @@ export enum AuthErrorTypes {
 	OAuthSignInError = 'oauthSignInError',
 }
 
-export type AuthErrorMessages = { [key in AuthErrorTypes]: AuthErrorMessage };
+export type AuthErrorMessages = Record<AuthErrorTypes, AuthErrorMessage>;
 
 export interface AuthErrorMessage {
 	message: string;
diff --git a/packages/auth/src/types/models.ts b/packages/auth/src/types/models.ts
@@ -251,9 +251,7 @@ export type AuthNextSignInStep<
  */
 export type AuthUserAttributes<
 	UserAttributeKey extends AuthUserAttributeKey = AuthUserAttributeKey,
-> = {
-	[Attribute in UserAttributeKey]?: string;
-};
+> = Partial<Record<UserAttributeKey, string>>;
 
 /**
  * The interface of a user attribute.
diff --git a/packages/auth/src/types/outputs.ts b/packages/auth/src/types/outputs.ts
@@ -40,6 +40,4 @@ export interface AuthUpdateUserAttributeOutput<
 
 export type AuthUpdateUserAttributesOutput<
 	UserAttributeKey extends AuthUserAttributeKey = AuthUserAttributeKey,
-> = {
-	[authKey in UserAttributeKey]: AuthUpdateUserAttributeOutput<UserAttributeKey>;
-};
+> = Record<UserAttributeKey, AuthUpdateUserAttributeOutput<UserAttributeKey>>;
diff --git a/packages/core/src/types/errors.ts b/packages/core/src/types/errors.ts
@@ -15,12 +15,13 @@ export interface AmplifyErrorParams<ErrorCode extends string = string> {
 	underlyingError?: Error | unknown;
 }
 
-export type AmplifyErrorMap<ErrorCode extends string = string> = {
-	[name in ErrorCode]: {
+export type AmplifyErrorMap<ErrorCode extends string = string> = Record<
+	ErrorCode,
+	{
 		message: string;
 		recoverySuggestion?: string;
-	};
-};
+	}
+>;
 
 export interface ServiceError {
 	name: string;
diff --git a/packages/datastore/src/sync/processors/errorMaps.ts b/packages/datastore/src/sync/processors/errorMaps.ts
@@ -3,9 +3,7 @@
 import { ErrorType } from '../../types';
 import { resolveServiceErrorStatusCode } from '../utils';
 
-export type ErrorMap = Partial<{
-	[key in ErrorType]: (error: Error) => boolean;
-}>;
+export type ErrorMap = Partial<Record<ErrorType, (error: Error) => boolean>>;
 
 const connectionTimeout = error =>
 	/^Connection failed: Connection Timeout/.test(error.message);
diff --git a/packages/datastore/src/sync/utils.ts b/packages/datastore/src/sync/utils.ts
@@ -840,14 +840,10 @@ export async function getModelAuthModes({
 	defaultAuthMode: GraphQLAuthMode;
 	modelName: string;
 	schema: InternalSchema;
-}): Promise<{
-	[key in ModelOperation]: GraphQLAuthMode[];
-}> {
+}): Promise<Record<ModelOperation, GraphQLAuthMode[]>> {
 	const operations = Object.values(ModelOperation);
 
-	const modelAuthModes: {
-		[key in ModelOperation]: GraphQLAuthMode[];
-	} = {
+	const modelAuthModes: Record<ModelOperation, GraphQLAuthMode[]> = {
 		CREATE: [],
 		READ: [],
 		UPDATE: [],
diff --git a/packages/datastore/src/types.ts b/packages/datastore/src/types.ts
@@ -1083,9 +1083,7 @@ export enum ModelOperation {
 
 export type ModelAuthModes = Record<
 	string,
-	{
-		[Property in ModelOperation]: GraphQLAuthMode[];
-	}
+	Record<ModelOperation, GraphQLAuthMode[]>
 >;
 
 export type SyncExpression = Promise<{
diff --git a/packages/pubsub/src/utils/ConnectionStateMonitor.ts b/packages/pubsub/src/utils/ConnectionStateMonitor.ts
@@ -17,18 +17,18 @@ interface LinkedConnectionStates {
 	keepAliveState: LinkedHealthState;
 }
 
-export const CONNECTION_CHANGE: {
-	[key in
-		| 'KEEP_ALIVE_MISSED'
-		| 'KEEP_ALIVE'
-		| 'CONNECTION_ESTABLISHED'
-		| 'CONNECTION_FAILED'
-		| 'CLOSING_CONNECTION'
-		| 'OPENING_CONNECTION'
-		| 'CLOSED'
-		| 'ONLINE'
-		| 'OFFLINE']: Partial<LinkedConnectionStates>;
-} = {
+export const CONNECTION_CHANGE: Record<
+	| 'KEEP_ALIVE_MISSED'
+	| 'KEEP_ALIVE'
+	| 'CONNECTION_ESTABLISHED'
+	| 'CONNECTION_FAILED'
+	| 'CLOSING_CONNECTION'
+	| 'OPENING_CONNECTION'
+	| 'CLOSED'
+	| 'ONLINE'
+	| 'OFFLINE',
+	Partial<LinkedConnectionStates>
+> = {
 	KEEP_ALIVE_MISSED: { keepAliveState: 'unhealthy' },
 	KEEP_ALIVE: { keepAliveState: 'healthy' },
 	CONNECTION_ESTABLISHED: { connectionState: 'connected' },
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ export enum AuthErrorTypes {`
`20`	`20`	`OAuthSignInError = 'oauthSignInError',`
`21`	`21`	`}`
`22`	`22`
`23`		`-export type AuthErrorMessages = { [key in AuthErrorTypes]: AuthErrorMessage };`
	`23`	`+export type AuthErrorMessages = Record<AuthErrorTypes, AuthErrorMessage>;`
`24`	`24`
`25`	`25`	`export interface AuthErrorMessage {`
`26`	`26`	`message: string;`