fix(Auth): Handling proper error when attempting to change password fails due to an expired session. (#1995)

Author: sebaland

AmplifyPlugins/Auth/AWSCognitoAuthPlugin/Dependency/AuthUserServiceAdapter.swift

@@ -146,16 +146,31 @@ class AuthUserServiceAdapter: AuthUserServiceBehavior {
                     completionHandler(.success(()))
                     return
                 }
-                if let awsMobileClientError = error as? AWSMobileClientError,
-                    case .notSignedIn = awsMobileClientError {
-                    let authError = AuthError.signedOut(
-                        AuthPluginErrorConstants.changePasswordSignedOutError.errorDescription,
-                        AuthPluginErrorConstants.changePasswordSignedOutError.recoverySuggestion, nil)
-                    completionHandler(.failure(authError))
-                } else {
+
+                guard let awsMobileClientError = error as? AWSMobileClientError else {
                     let authError = AuthErrorHelper.toAuthError(error)
                     completionHandler(.failure(authError))
+                    return
+                }
+
+                let authError: AuthError
+                switch awsMobileClientError {
+                case .notSignedIn:
+                    authError = AuthError.signedOut(
+                        AuthPluginErrorConstants.changePasswordSignedOutError.errorDescription,
+                        AuthPluginErrorConstants.changePasswordSignedOutError.recoverySuggestion,
+                        nil
+                )
+                case .unableToSignIn:
+                    authError = AuthError.sessionExpired(
+                        AuthPluginErrorConstants.changePasswordUnableToSignInError.errorDescription,
+                        AuthPluginErrorConstants.changePasswordUnableToSignInError.recoverySuggestion,
+                        nil
+                    )
+                default:
+                    authError = AuthErrorHelper.toAuthError(error)
                 }
+                completionHandler(.failure(authError))
         }
 
     }

AmplifyPlugins/Auth/AWSCognitoAuthPlugin/Support/Constants/AuthPluginErrorConstants.swift

@@ -139,6 +139,10 @@ struct AuthPluginErrorConstants {
     static let changePasswordSignedOutError: AuthPluginErrorString = (
     "Could not change password, there is no user signed in to the Auth category",
     "Change password require a user signed in to Auth category, use one of the signIn apis to signIn")
+
+    static let changePasswordUnableToSignInError: AuthPluginErrorString = (
+    "Could not change password, the user session is expired",
+    "Re-authenticate the user by using one of the signIn apis")
 }
 
 // Field validation errors