fix(DataStore): include table name inside quotes in SQL Update statement (#1824)

* fix(DataStore): include table name inside quotes in SQL Update statement

* Include table name in quotes for alter and drop table statements

Author: thisisabhash

AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Storage/SQLite/SQLStatement+AlterTable.swift

@@ -14,7 +14,7 @@ struct AlterTableStatement: SQLStatement {
     var modelSchema: ModelSchema
 
     var stringValue: String {
-        return "ALTER TABLE \(fromModelSchema.name) RENAME TO \(modelSchema.name)"
+        return "ALTER TABLE \"\(fromModelSchema.name)\" RENAME TO \"\(modelSchema.name)\""
     }
 
     init(from fromModelSchema: ModelSchema, toModelSchema: ModelSchema) {

AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Storage/SQLite/SQLStatement+DropTable.swift

@@ -14,7 +14,7 @@ struct DropTableStatement: SQLStatement {
     var modelSchema: ModelSchema
 
     var stringValue: String {
-        return "DROP TABLE IF EXISTS \(modelSchema.name)"
+        return "DROP TABLE IF EXISTS \"\(modelSchema.name)\""
     }
 
     init(modelSchema: ModelSchema) {

AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Storage/SQLite/SQLStatement+Update.swift

@@ -39,7 +39,7 @@ struct UpdateStatement: SQLStatement {
         }
 
         var sql = """
-        update \(modelSchema.name)
+        update "\(modelSchema.name)"
         set
         \(columnsStatement.joined(separator: ",\n"))
         where \(modelSchema.primaryKey.columnName()) = ?

AmplifyPlugins/DataStore/AWSDataStoreCategoryPluginTests/Core/SQLStatementTests.swift

@@ -235,7 +235,7 @@ class SQLStatementTests: XCTestCase {
         let statement = UpdateStatement(model: post, modelSchema: post.schema)
 
         let expectedStatement = """
-        update Post
+        update "Post"
         set
           "content" = ?,
           "createdAt" = ?,
@@ -266,7 +266,7 @@ class SQLStatementTests: XCTestCase {
         let statement = UpdateStatement(model: post, modelSchema: post.schema, condition: condition)
 
         let expectedStatement = """
-        update Post
+        update "Post"
         set
           "content" = ?,
           "createdAt" = ?,

AmplifyPlugins/DataStore/AWSDataStoreCategoryPluginTests/Migration/SQLiteMutationSyncMetadataMigrationDelegateTests.swift

@@ -120,7 +120,9 @@ class SQLiteMutationSyncMetadataMigrationDelegateTests: MutationSyncMetadataMigr
         // Dropping the table without the table in the database is successful
         let drop = try delegate.removeMutationSyncMetadataCopyStore()
 
-        XCTAssertEqual(drop, "DROP TABLE IF EXISTS MutationSyncMetadataCopy")
+        XCTAssertEqual(drop, """
+        DROP TABLE IF EXISTS "MutationSyncMetadataCopy"
+        """)
 
         // Creating the table is successful
         let create = try delegate.createMutationSyncMetadataCopyStore()

AmplifyPlugins/DataStore/Podfile.lock

@@ -127,4 +127,4 @@ SPEC CHECKSUMS:
 
 PODFILE CHECKSUM: 07ff9134d58a47ca475ed1439261458407a9b1f3
 
-COCOAPODS: 1.11.3
+COCOAPODS: 1.11.2

Podfile.lock

@@ -1,5 +1,5 @@
 PODS:
-  - AWSCore (2.27.0)
+  - AWSCore (2.27.9)
   - CwlCatchException (2.1.1):
     - CwlCatchExceptionSupport (~> 2.1.1)
   - CwlCatchExceptionSupport (2.1.1)
@@ -10,7 +10,7 @@ PODS:
     - CwlMachBadInstructionHandler (~> 2.1.0)
     - CwlPosixPreconditionTesting (~> 2.1.0)
   - SwiftFormat/CLI (0.44.17)
-  - SwiftLint (0.46.2)
+  - SwiftLint (0.47.1)
 
 DEPENDENCIES:
   - AWSCore (~> 2.27.0)
@@ -39,15 +39,15 @@ CHECKOUT OPTIONS:
     :tag: 2.1.0
 
 SPEC CHECKSUMS:
-  AWSCore: d605449939e5b40704f11ff9f91f905f7d978589
+  AWSCore: 3419bcaeec8d7809efa32f0e83f151ef8e93ad78
   CwlCatchException: 86760545af2a490a23e964d76d7c77442dbce79b
   CwlCatchExceptionSupport: a004322095d7101b945442c86adc7cec0650f676
   CwlMachBadInstructionHandler: aa1fe9f2d08b29507c150d099434b2890247e7f8
   CwlPosixPreconditionTesting: 1ba4471964405941f79b3f06bbcf3c2be782950c
   CwlPreconditionTesting: 73ae5de517a8761e5e40fb4136c6a26365af0440
   SwiftFormat: 3b5caa6389b2b9adbc00e133b3ccc8c6e687a6a4
-  SwiftLint: 6bc52a21f0fd44cab9aa2dc8e534fb9f5e3ec507
+  SwiftLint: f80f1be7fa96d30e0aa68e58d45d4ea1ccaac519
 
 PODFILE CHECKSUM: 5e20e56b8ef40444b018a3736b7b726ff9772f00
 
-COCOAPODS: 1.11.3
+COCOAPODS: 1.11.2